new config searching path

README.md

@@ -109,6 +109,7 @@ one of these locations:
    more details [here](https://en.opensuse.org/openSUSE:Packaging_UsrEtc).
 1. `/etc/kuberlr.conf`
 1. `$HOME/.kuberlr/kuberlr.conf`
+1. `$KUBERLR_CFG`
 
 The configuration files are read in the order written above and merged together.
 Configuration files can override the values defined by the previous ones, or

internal/config/config.go

@@ -2,7 +2,6 @@ package config
 
 import (
 	"os"
-	"path/filepath"
 
 	"github.com/spf13/viper"
 
@@ -21,7 +20,7 @@ type Cfg struct {
 // directories.
 func NewCfg() *Cfg {
 	return &Cfg{
-		Paths: configPaths,
+		Paths: configFiles,
 	}
 }
 
@@ -58,9 +57,7 @@ func (c *Cfg) GetKubeMirrorURL() (string, error) {
 	return v.GetString("KubeMirrorUrl"), nil
 }
 
-func mergeConfig(v *viper.Viper, extraConfigPath string) error {
-	cfgFile := filepath.Join(extraConfigPath, "kuberlr.conf")
-
+func mergeConfig(v *viper.Viper, cfgFile string) error {
 	_, err := os.Stat(cfgFile)
 	if err != nil {
 		if os.IsNotExist(err) {

internal/config/config_test.go

@@ -57,7 +57,11 @@ func TestOnlySystemConfigExists(t *testing.T) {
 	}
 
 	c := Cfg{
-		Paths: []string{td.FakeUsrEtc, td.FakeEtc, td.FakeHome},
+		Paths: []string{
+			filepath.Join(td.FakeUsrEtc, "kuberlr.conf"),
+			filepath.Join(td.FakeEtc, "kuberlr.conf"),
+			filepath.Join(td.FakeHome, "kuberlr.conf"),
+		},
 	}
 
 	v, err := c.Load()
@@ -86,7 +90,11 @@ func TestHomeConfigOverridesSystemOne(t *testing.T) {
 	}
 
 	c := Cfg{
-		Paths: []string{td.FakeUsrEtc, td.FakeEtc, td.FakeHome},
+		Paths: []string{
+			filepath.Join(td.FakeUsrEtc, "kuberlr.conf"),
+			filepath.Join(td.FakeEtc, "kuberlr.conf"),
+			filepath.Join(td.FakeHome, "kuberlr.conf"),
+		},
 	}
 
 	v, err := c.Load()
@@ -132,7 +140,12 @@ AllowDownload = true
 	}
 
 	c := Cfg{
-		Paths: []string{td.FakeUsrEtc, td.FakeEtc, td.FakeHome},
+		Paths: []string{
+			filepath.Join(td.FakeUsrEtc, "kuberlr.conf"),
+			filepath.Join(td.FakeEtc, "kuberlr.conf"),
+			filepath.Join(td.FakeHome, "kuberlr.conf"),
+			os.Getenv("__FAKE_ENV__"),
+		},
 	}
 
 	v, err := c.Load()

internal/config/paths_unix.go

@@ -4,13 +4,15 @@
 package config
 
 import (
+	"os"
 	"path/filepath"
 
 	"github.com/flavio/kuberlr/internal/common"
 )
 
-var configPaths = []string{ //nolint: gochecknoglobals // arrays cannot be go constants
-	"/usr/etc/",
-	"/etc/",
-	filepath.Join(common.HomeDir(), ".kuberlr"),
+var configFiles = []string{ //nolint: gochecknoglobals // arrays cannot be go constants
+	"/usr/etc/kuberlr.conf",
+	"/etc/kuberlr.conf",
+	filepath.Join(common.HomeDir(), ".kuberlr", "kuberlr.conf"),
+	os.Getenv("KUBERLR_CFG"),
 }

internal/config/paths_windows.go

@@ -4,13 +4,15 @@
 package config
 
 import (
-	"github.com/flavio/kuberlr/internal/common"
 	"os"
 	"path/filepath"
+
+	"github.com/flavio/kuberlr/internal/common"
 )
 
-var configPaths = []string{
-	filepath.Join(os.Getenv("APPDATA"), "kuberlr"),
-	filepath.Join(os.Getenv("PROGRAMDATA"), "kuberlr"),
-	filepath.Join(common.HomeDir(), ".kuberlr"),
+var configFiles = []string{
+	filepath.Join(os.Getenv("APPDATA"), "kuberlr", "kuberlr.conf"),
+	filepath.Join(os.Getenv("PROGRAMDATA"), "kuberlr", "kuberlr.conf"),
+	filepath.Join(common.HomeDir(), ".kuberlr", "kuberlr.conf"),
+	os.Getenv("KUBERLR_CFG"),
 }