Fix: search engine is required, incorrect resource ids being provided #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ricted_instances method
taylorn01
commented
Jun 25, 2024
| @@ -389,7 +390,7 @@ def get(self, request, nodeid, zoom, x, y): | |||
| ) AS geom, | |||
| 1 AS total | |||
| FROM geojson_geometries | |||
| WHERE nodeid = %s and resourceinstanceid not in %s) AS tile;""", | |||
| WHERE nodeid = %s and resourceinstanceid in %s) AS tile;""", | |||
There was a problem hiding this comment.
Didn't realise I committed this line this is the hacky change I'm not confident in but I'm about to test if it has an impact
There was a problem hiding this comment.
Yeah this is very much required for it to work. This could be related to an inverse affect in the new permission system. If the old system expected a list of resource IDs it's not allowed access to and the new system expects it to provide a list it has access to.
I'm speculating but it's a possibility that needs looked into further.
taylorn01
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test that selecting different map layers will render the geometry's for it