-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better error messages #15
Better error messages #15
Conversation
Couple of caveats:
|
Co-authored-by: Ellery Ames <[email protected]>
Co-authored-by: Ellery Ames <[email protected]>
Co-authored-by: Ellery Ames <[email protected]>
Co-authored-by: Ellery Ames <[email protected]>
Co-authored-by: Ellery Ames <[email protected]>
Captures a traceback, for debugging if this does not work. | ||
|
||
WARNING: this is one of the few places that we would expect | ||
dask distributed to break, if running outside a single process |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder about this warning. As far as I know dask.distributed
is not a dependency of ours here. I can see warning/pointing out failure points for future developers (including our future selves) thinking of extending this package for parallel execution.
Separately, the internal lazy construct is supposed to be library agnostic (so in principle users can use dask, ray, etc backends), so should we perhaps make the warning library agnostic as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your patience @philtweir !
Co-authored-by: Ellery Ames <[email protected]>
Implements several closely related features:
error messages show location of call, not lazy-evaluation, if possiblecustom type errors are more specificexamples in the custom error messages