Updated fitBounds to handle rotation #1550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
JaffaKetchup
requested changes
Jun 10, 2023
There was a problem hiding this comment.
Hey @jjoelson, and thanks for the fix!
The fix looks good, but I'm not sure 72 tests are necessary :).
Could probably get away with doing it in iterations of 30 deg, or even 60 deg.
5 tasks
jjoelson
force-pushed
the
1342-fix-fit-bounds
branch
from
b0550a4
to
dc94485
Compare
I wrote a bit of code to generate the tests and it's possible I got a bit carried away using it. 😅 I just updated the PR to use 60 deg increments. |
JaffaKetchup
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the discussion in #1549, here's a separate PR to address #1342.
I've added tests for no padding, symmetric padding, and asymmetric padding for every 10 degree interval between -360 and 360. Here are visuals of the test cases:
No padding:
fitBounds.-.no.padding.mov
Symmetric padding:
fitBounds.-.symmetric.padding.mov
Asymmetric padding:
fitBounds.-.asymmetric.padding.mov