-
-
Notifications
You must be signed in to change notification settings - Fork 860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major State Refactoring #1551
Major State Refactoring #1551
Commits on Jun 20, 2023
-
Split FlutterMapState in to a stateful container widget (FlutterMapSt…
…ateContainer) and an immutable representation of the state of the map (FlutterMapState)
Configuration menu - View commit details
-
Copy full SHA for 4cd53e8 - Browse repository at this point
Copy the full SHA 4cd53e8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 41a41af - Browse repository at this point
Copy the full SHA 41a41afView commit details -
Move gesture initialisation out of builder and stop passing the whole…
… FlutterMapStateContainer to InteractionDetector
Configuration menu - View commit details
-
Copy full SHA for afa3c78 - Browse repository at this point
Copy the full SHA afa3c78View commit details -
Configuration menu - View commit details
-
Copy full SHA for f389195 - Browse repository at this point
Copy the full SHA f389195View commit details -
Configuration menu - View commit details
-
Copy full SHA for ff484a1 - Browse repository at this point
Copy the full SHA ff484a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0746a0b - Browse repository at this point
Copy the full SHA 0746a0bView commit details -
Reduce MapController API size and simplify gesture code
- Replaced mapState getter with the various getters which were just proxied to MapState. - Heavy refactoring (hopefully without changing behaviour) of gesture code. In passing I have simplified
Configuration menu - View commit details
-
Copy full SHA for 8be935b - Browse repository at this point
Copy the full SHA 8be935bView commit details -
Remove unnecessary getters now that InteractiveFlags defines convenie…
…nce methods for checking single flags
Configuration menu - View commit details
-
Copy full SHA for 21ae265 - Browse repository at this point
Copy the full SHA 21ae265View commit details -
Fix double tap zoom not working when drag was enabled and prevent pin…
…ch move when only pinch zoom is enabled
Configuration menu - View commit details
-
Copy full SHA for 5d4298c - Browse repository at this point
Copy the full SHA 5d4298cView commit details -
Configuration menu - View commit details
-
Copy full SHA for b1fba18 - Browse repository at this point
Copy the full SHA b1fba18View commit details -
Configuration menu - View commit details
-
Copy full SHA for 32d57e0 - Browse repository at this point
Copy the full SHA 32d57e0View commit details -
Replace http stubbing with an in-memory TileProvider in tests
This stops the following message from being spammed in tests which was caused by a problem with the http mocking: type 'Null' is not a subtype of type 'Future<HttpClientRequest>'
Configuration menu - View commit details
-
Copy full SHA for 3bc6ca4 - Browse repository at this point
Copy the full SHA 3bc6ca4View commit details -
Separate MapOptions from FlutterMapState
In doing so I noticed that the adaptive boundary options could use a refactor and so placed them in a dedicated class which led to a tidy up to the boundary code in FlutterMapState.
Configuration menu - View commit details
-
Copy full SHA for 0a9a05f - Browse repository at this point
Copy the full SHA 0a9a05fView commit details -
Combine adaptive bounds, max bounds and sw/ne pan bounds in to a sing…
…le MapBounds class
Configuration menu - View commit details
-
Copy full SHA for d5a8acb - Browse repository at this point
Copy the full SHA d5a8acbView commit details -
Create FrameConstraint and FrameFit abstraction
FrameConstraint unites the various methods of setting a maximum bounds for the map frame. Previously MapOptions had three different concepts for setting a max bounds: adaptive bounds, maxBounds and se/nw pan boundaries. Adaptive bounds and maxBounds are now FrameConstraint.contain whilst sw/ne pan boundaries is replaced by FrameConstraint.containCenter. FrameFit is a replacement for FitBoundsOptions, combinining the options with the bounds. This means bounds/boundsOptions now become initialFrameFit (since bounds/boundsOptions were actually initial bounds and the options for those initial bounds). Additionally this sets up an abstraction for different map fits since coordinate fit will be added next.
Configuration menu - View commit details
-
Copy full SHA for 8ac52f9 - Browse repository at this point
Copy the full SHA 8ac52f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for d16bc55 - Browse repository at this point
Copy the full SHA d16bc55View commit details -
This commit incorporates @jjoelson's coordinate fit implementation in to the new FrameFit abstraction. Co-authored-by: Jonathan Joelson <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for dae90c8 - Browse repository at this point
Copy the full SHA dae90c8View commit details -
Rename FlutterMapState to FlutterMapFrame, add InteractionOptions col…
…lection to tidy up options and change how options are propagated in preparation for changing the inherited widget to an inherited model
Configuration menu - View commit details
-
Copy full SHA for f4d5a04 - Browse repository at this point
Copy the full SHA f4d5a04View commit details -
Configuration menu - View commit details
-
Copy full SHA for 66e508d - Browse repository at this point
Copy the full SHA 66e508dView commit details -
Remove FitCoordinates' inside parameter because fitting inside a set …
…of coordinates doesn't have an unambiguous meaning
Configuration menu - View commit details
-
Copy full SHA for ced3a03 - Browse repository at this point
Copy the full SHA ced3a03View commit details -
Configuration menu - View commit details
-
Copy full SHA for 24263d2 - Browse repository at this point
Copy the full SHA 24263d2View commit details -
Set constraints that match the old adaptive constraints
These old adaptive constraints did not prevent the map from going outside of the specified bounds, they stopped the center of the map from going outside of those bounds. This commit sets the constraints appropriately.
Configuration menu - View commit details
-
Copy full SHA for f5f5735 - Browse repository at this point
Copy the full SHA f5f5735View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3cbea21 - Browse repository at this point
Copy the full SHA 3cbea21View commit details -
Use flags/options from InteractionOptions not the old deprecated valu…
…es, unless InteractiveOptions is not provided
Configuration menu - View commit details
-
Copy full SHA for b7b5bf2 - Browse repository at this point
Copy the full SHA b7b5bf2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4e60392 - Browse repository at this point
Copy the full SHA 4e60392View commit details -
Add tests to make sure the InheritedModel notifies if and only if the…
… relevnat aspect changes
Configuration menu - View commit details
-
Copy full SHA for 3e4413c - Browse repository at this point
Copy the full SHA 3e4413cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3a0c0bb - Browse repository at this point
Copy the full SHA 3a0c0bbView commit details -
Configuration menu - View commit details
-
Copy full SHA for ccea34a - Browse repository at this point
Copy the full SHA ccea34aView commit details -
Configuration menu - View commit details
-
Copy full SHA for bdae8ef - Browse repository at this point
Copy the full SHA bdae8efView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4dedb1c - Browse repository at this point
Copy the full SHA 4dedb1cView commit details -
Configuration menu - View commit details
-
Copy full SHA for b743773 - Browse repository at this point
Copy the full SHA b743773View commit details -
Move FlutterMapStateContainer in to FlutterMap's file since it is jus…
…t the widget state
Configuration menu - View commit details
-
Copy full SHA for 7f0a386 - Browse repository at this point
Copy the full SHA 7f0a386View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4c99df7 - Browse repository at this point
Copy the full SHA 4c99df7View commit details -
Configuration menu - View commit details
-
Copy full SHA for cbf26b4 - Browse repository at this point
Copy the full SHA cbf26b4View commit details -
Use standard deprecations format
In passing re-ordered the methods in MapControllerImpl to match MapController.
Configuration menu - View commit details
-
Copy full SHA for 354e6d3 - Browse repository at this point
Copy the full SHA 354e6d3View commit details
Commits on Jun 21, 2023
-
Re-organized camera related source files
Improved some documentation (part 1) Prevent public exposure of `FitCoordinates` and `FitBounds` constructors
Configuration menu - View commit details
-
Copy full SHA for dabf734 - Browse repository at this point
Copy the full SHA dabf734View commit details
Commits on Jun 27, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 9e775c6 - Browse repository at this point
Copy the full SHA 9e775c6View commit details -
Move CameraFit attributes from the base class to the subclasses and t…
…idy up documentation None of the fields which were on the CameraFit base class were conceptually essential for any imaginable camera fit. Moving them to the subclasses ensures that any future camera fits will not need to implement those options just because they already exist. It would also allow for individual camera fits to specify different default values if appropriate.
Configuration menu - View commit details
-
Copy full SHA for 955e066 - Browse repository at this point
Copy the full SHA 955e066View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b40381 - Browse repository at this point
Copy the full SHA 2b40381View commit details -
Configuration menu - View commit details
-
Copy full SHA for d0ad93c - Browse repository at this point
Copy the full SHA d0ad93cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5750b6a - Browse repository at this point
Copy the full SHA 5750b6aView commit details -
Remove duplicate exports and make imports consistent
The plugin API no longer exports classes which flutter_map already exports. Imports within this package now import the actual classes they use rather than the whole flutter_map library. Internal code should not depend on the exported library definition.
Configuration menu - View commit details
-
Copy full SHA for 5d8aca1 - Browse repository at this point
Copy the full SHA 5d8aca1View commit details
Commits on Jul 5, 2023
-
Configuration menu - View commit details
-
Copy full SHA for f986d77 - Browse repository at this point
Copy the full SHA f986d77View commit details -
Configuration menu - View commit details
-
Copy full SHA for f5d6d13 - Browse repository at this point
Copy the full SHA f5d6d13View commit details -
Configuration menu - View commit details
-
Copy full SHA for 150213e - Browse repository at this point
Copy the full SHA 150213eView commit details
Commits on Jul 6, 2023
-
Set default CameraFit maxZoom values to null
The other parameters for CameraFit all have default values which will not cause changes to the calculated CameraFit (i.e. padding is zero, forceIntegerZoomLevel is false). Setting maxZoom to null makes it consistent with the other parameters in that it will not affect the calculated CameraFit. I chose null over double.infinity as in my opinion the intent is clearer, no maximum.
Configuration menu - View commit details
-
Copy full SHA for c327723 - Browse repository at this point
Copy the full SHA c327723View commit details