Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test to prevent future gesture detection regressions #1584

Commits on Jul 13, 2023

  1. Add test to ensure gestures always work

    Recently a change was made to move the TileLayer backgroundColor option
    to become an option of FlutterMap. This accidentally fixed an issue
    where gestures would stop working when going beyond a TileLayer's max
    zoom because FlutterMap's gesture detectors' HitTestBehaviour is the
    default deferToChild and when above a TileLayer's maxZoom potentially
    there would be no hit-testable children of FlutterMap.
    
    Moving the color option to FlutterMap means that there is always a
    ColoredBox child widget which is hit testable. To avoid accidentally
    breaking hit testing again in the future this commit adds a test which
    ensures it always works.
    
    In passing I made TileLayer only wrap its tiles in a ColoredBox widget
    if the user defines a backgroundColor (which is deprecated).
    rorystephenson committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    7247796 View commit details
    Browse the repository at this point in the history