Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multi!: rewrite gesture handling #1733

Closed
wants to merge 113 commits into from
Closed

multi!: rewrite gesture handling #1733

wants to merge 113 commits into from

Commits on Nov 25, 2023

  1. tap, longPress, secondaryTap, drag, scroll gestures

    @josxha
    josxha committed Nov 25, 2023
    Configuration menu
    Copy the full SHA
    c8f3961 View commit details
    Browse the repository at this point in the history

  2. doubleClick, rename multiFingerGestureStart

    @josxha
    josxha committed Nov 25, 2023
    Configuration menu
    Copy the full SHA
    c409de6 View commit details
    Browse the repository at this point in the history

  3. remove PositionedTapDetector2

    @josxha
    josxha committed Nov 25, 2023
    Configuration menu
    Copy the full SHA
    76b2e8f View commit details
    Browse the repository at this point in the history

  4. create gesture classes

    @josxha
    josxha committed Nov 25, 2023
    Configuration menu
    Copy the full SHA
    2358885 View commit details
    Browse the repository at this point in the history

  5. fix double tap and co

    @josxha
    josxha committed Nov 25, 2023
    Configuration menu
    Copy the full SHA
    184951b View commit details
    Browse the repository at this point in the history

  6. check if gesture is enabled, add tertiary and secondaryLongPress call… 

    …backs
    @josxha
    josxha committed Nov 25, 2023
    Configuration menu
    Copy the full SHA
    ebef123 View commit details
    Browse the repository at this point in the history

  7. remove prefix from class, match file names

    @josxha
    josxha committed Nov 25, 2023
    Configuration menu
    Copy the full SHA
    ec57c70 View commit details
    Browse the repository at this point in the history

  8. fix new gestures

    @josxha
    josxha committed Nov 25, 2023
    Configuration menu
    Copy the full SHA
    c863202 View commit details
    Browse the repository at this point in the history

  9. fix enable scroll wheel gesture check

    @josxha
    josxha committed Nov 25, 2023
    Configuration menu
    Copy the full SHA
    499f77a View commit details
    Browse the repository at this point in the history

  10. use dedicated event classes for new map events

    @josxha
    josxha committed Nov 25, 2023
    Configuration menu
    Copy the full SHA
    1f87645 View commit details
    Browse the repository at this point in the history

  11. add DoubleTapDragZoomGesture

    @josxha
    josxha committed Nov 25, 2023
    Configuration menu
    Copy the full SHA
    6c9ea3f View commit details
    Browse the repository at this point in the history

  12. remove MultiFingerGesture 

    non breaking commit
    @josxha
    josxha committed Nov 25, 2023
    Configuration menu
    Copy the full SHA
    d9088b3 View commit details
    Browse the repository at this point in the history

  13. fix rebase

    @josxha
    josxha committed Nov 25, 2023
    Configuration menu
    Copy the full SHA
    95a25b4 View commit details
    Browse the repository at this point in the history

  14. add CtrlDragRotateGesture

    @josxha
    josxha committed Nov 25, 2023
    Configuration menu
    Copy the full SHA
    beaeb44 View commit details
    Browse the repository at this point in the history

  15. remove TapPosition

    @josxha
    josxha committed Nov 25, 2023
    Configuration menu
    Copy the full SHA
    451ceac View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2023

  1. pass full gesture event alongside the callback

    @josxha
    josxha committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    fdd0788 View commit details
    Browse the repository at this point in the history

  2. add twoFingerRotate, twoFingerZoom, twoFingerMove

    @josxha
    josxha committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    41348c2 View commit details
    Browse the repository at this point in the history

  3. add pointer event callbacks

    @josxha
    josxha committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    7c744de View commit details
    Browse the repository at this point in the history

  4. add thresholds for two finger gestures

    @josxha
    josxha committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    a2b2148 View commit details
    Browse the repository at this point in the history

  5. add gesture, remove zoom and rotate threshold

    @josxha
    josxha committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    158dfb1 View commit details
    Browse the repository at this point in the history

  6. change default scroll wheel velocity

    @josxha
    josxha committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    09be7e7 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2023

  1. Delete internal_map_controller.dart

    @josxha
    josxha committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    30fded1 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into gesture-handling

    @josxha
    josxha committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    9b005c8 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2023

  1. Merge branch 'master' into gesture-handling

    @josxha
    josxha committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    e278e3e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into gesture-handling

    @josxha
    josxha committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    e75b187 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2023

  1. Merge branch 'master' into gesture-handling

    @josxha
    josxha committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    c908173 View commit details
    Browse the repository at this point in the history

  2. fix imports

    @josxha
    josxha committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    f25abcc View commit details
    Browse the repository at this point in the history

  3. fix merge

    @josxha
    josxha committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    26f24e6 View commit details
    Browse the repository at this point in the history

  4. add doubleTapZoomIn

    @josxha
    josxha committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    7166dcd View commit details
    Browse the repository at this point in the history

  5. fix DragGesture end callback

    @josxha
    josxha committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    7db3361 View commit details
    Browse the repository at this point in the history

  6. stop animation on gesture input

    @josxha
    josxha committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    0c6e859 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2023

  1. add flingAnimation

    @josxha
    josxha committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    2ea24e0 View commit details
    Browse the repository at this point in the history

  2. Update flutter_map_test.dart

    @josxha
    josxha committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    ec0cef7 View commit details
    Browse the repository at this point in the history

  3. Update full_coverage_test.dart

    @josxha
    josxha committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    e3738a1 View commit details
    Browse the repository at this point in the history

  4. use bool fields for interactiveFlags, keep support for bitfield

    @josxha
    josxha committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    92e360b View commit details
    Browse the repository at this point in the history

  5. small improvements

    @josxha
    josxha committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    f3c5e21 View commit details
    Browse the repository at this point in the history

  6. disable double clicks

    @josxha
    josxha committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    9202645 View commit details
    Browse the repository at this point in the history

  7. optional double click and scale callbacks

    @josxha
    josxha committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    e59f4da View commit details
    Browse the repository at this point in the history

  8. remove null checks

    @josxha
    josxha committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    cefacc3 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2023

  1. add docs

    @josxha
    josxha committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    f32cca2 View commit details
    Browse the repository at this point in the history

  2. refactor, turn MoveAndRotateResult to a class

    @josxha
    josxha committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    794e9ba View commit details
    Browse the repository at this point in the history

  3. fix imports

    @josxha
    josxha committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    91f77dc View commit details
    Browse the repository at this point in the history

  4. move map events to the controller

    @josxha
    josxha committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    1ec5152 View commit details
    Browse the repository at this point in the history

  5. move gestures to map directory

    @josxha
    josxha committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    94b687d View commit details
    Browse the repository at this point in the history

  6. move things around

    @josxha
    josxha committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    7d61515 View commit details
    Browse the repository at this point in the history

  7. clean up typedefs

    @josxha
    josxha committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    3b7b08d View commit details
    Browse the repository at this point in the history

  8. clean up

    @josxha
    josxha committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    1fce148 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2023

  1. revert rename of TapCallback

    @josxha
    josxha committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    a1084fc View commit details
    Browse the repository at this point in the history

  2. remove pinchZoomWinGestures option

    @josxha
    josxha committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    121da5e View commit details
    Browse the repository at this point in the history

  3. remove IsKeyCursorRotationTrigger typdef

    @josxha
    josxha committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    0f10eb9 View commit details
    Browse the repository at this point in the history

  4. dart format

    @josxha
    josxha committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    cb45f99 View commit details
    Browse the repository at this point in the history

  5. remove CursorKeyboardRotationOptions

    @josxha
    josxha committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    e2a2e40 View commit details
    Browse the repository at this point in the history

  6. add docs, add ctrlRotateKeys to the hashKey and == function

    @josxha
    josxha committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    9f1d4a1 View commit details
    Browse the repository at this point in the history

  7. update docs

    @josxha
    josxha committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    b0c0b5f View commit details
    Browse the repository at this point in the history

  8. rename InteractiveFlag fields

    @josxha
    josxha committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    dcc07b8 View commit details
    Browse the repository at this point in the history

  9. clean up

    @josxha
    josxha committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    b93e02a View commit details
    Browse the repository at this point in the history

  10. consistent naming

    @josxha
    josxha committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    134efa1 View commit details
    Browse the repository at this point in the history

  11. refactor

    @josxha
    josxha committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    ee7bf4a View commit details
    Browse the repository at this point in the history

  12. use threshhold options for two finger gestures

    @josxha
    josxha committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    950fdd1 View commit details
    Browse the repository at this point in the history

  13. adjust threshholds

    @josxha
    josxha committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    4ac22eb View commit details
    Browse the repository at this point in the history

  14. clean up

    @josxha
    josxha committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    c221060 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2023

  1. refactor

    @josxha
    josxha committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    5dfe784 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into gesture-handling

    @josxha
    josxha committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    ed0556d View commit details
    Browse the repository at this point in the history

  3. split gesture service into more files

    @josxha
    josxha committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    7bef3eb View commit details
    Browse the repository at this point in the history

  4. use delta to start value for threshold

    @josxha
    josxha committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    15d8658 View commit details
    Browse the repository at this point in the history

  5. fix: two finger gestures don't comply with options

    @josxha
    josxha committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    876c098 View commit details
    Browse the repository at this point in the history

  6. adjust thresholds one last time

    @josxha
    josxha committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    2c22a95 View commit details
    Browse the repository at this point in the history

  7. fix map events

    @josxha
    josxha committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    f9bcdc7 View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2023

  1. TertiaryLongPressGestureService is no delayed gesture

    @josxha
    josxha committed Dec 17, 2023
    Configuration menu
    Copy the full SHA
    2309026 View commit details
    Browse the repository at this point in the history

  2. fix refactoring 

    fleaflet#1733 (comment)
    @josxha
    josxha committed Dec 17, 2023
    Configuration menu
    Copy the full SHA
    f0904ea View commit details
    Browse the repository at this point in the history

  3. rename wither 

    fleaflet#1733 (comment)
    @josxha
    josxha committed Dec 17, 2023
    Configuration menu
    Copy the full SHA
    48e1a3b View commit details
    Browse the repository at this point in the history

  4. small fix in docs

    @josxha
    josxha committed Dec 17, 2023
    Configuration menu
    Copy the full SHA
    be56976 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2023

  1. fix disable double tap in example pages with clicks 

    fleaflet#1733 (comment)
    @josxha
    josxha committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    5aa3aff View commit details
    Browse the repository at this point in the history

  2. rename groups constructor to byGroup 

    fleaflet#1733 (comment)
    @josxha
    josxha committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    e2c7827 View commit details
    Browse the repository at this point in the history

  3. update label "Two finger drag" 

    fleaflet#1733 (comment)
    @josxha
    josxha committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    9c117cb View commit details
    Browse the repository at this point in the history

  4. remove MoveAndRotateResult 

    fleaflet#1733 (comment)
    @josxha
    josxha committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    15697d7 View commit details
    Browse the repository at this point in the history

  5. public default constructor for EnabledGestures 

    fleaflet#1733 (comment)
    @josxha
    josxha committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    5df6045 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2023

  1. use byGroup constructor for noRotation constructor

    @josxha
    josxha committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    39faadc View commit details
    Browse the repository at this point in the history

  2. use static field for default keyboard keys

    @josxha
    josxha committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    00a0dc4 View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2024

  1. Merge branch 'master' into gesture-handling

    @josxha
    josxha committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    3be89b7 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2024

  1. Merge branch 'master' into gesture-handling

    @josxha
    josxha committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    a49ad6c View commit details
    Browse the repository at this point in the history

  2. rename CtrlDragRotate to KeyTriggerDrag gesture 

    fleaflet#1733 (comment)
    @josxha
    josxha committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    905abbd View commit details
    Browse the repository at this point in the history

  3. rename DelayedGestureService to BaseDetailsGestureService 

    fleaflet#1733 (comment)
    @josxha
    josxha committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    6809dad View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2024

  1. add docs

    @josxha
    josxha committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    6d90dd3 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into gesture-handling

    @josxha
    josxha committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    9916541 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2024

  1. rename BaseDetailsGestureService to SingleShotGestureService

    @josxha
    josxha committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    8a4995b View commit details
    Browse the repository at this point in the history

  2. introduce SetTapDownDetailsMixin

    @josxha
    josxha committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    ca81357 View commit details
    Browse the repository at this point in the history

  3. add ProgressableGestureService , BaseLongPressGestureService, remove … 

    …SetTapDownDetailsMixin
    @josxha
    josxha committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    64d6892 View commit details
    Browse the repository at this point in the history

  4. stop gesture animation by any onPointerDown event 

    fleaflet#1429 (comment)
    @josxha
    josxha committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    c102197 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2024

  1. Merge branch 'master' into gesture-handling

    @josxha
    josxha committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    cd4b7eb View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2024

  1. create getter for MapControllerImpl

    @josxha
    josxha committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    9a39009 View commit details
    Browse the repository at this point in the history

  2. remove obsolete controller.stopAnimationRaw() from services

    @josxha
    josxha committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    9956ada View commit details
    Browse the repository at this point in the history

  3. Merge branch 'gesture-handling' into gesture-service-setDetails-as-mixin

    @josxha
    josxha committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    a19e580 View commit details
    Browse the repository at this point in the history

  4. clean up methods 

    no longer necessary to cancel animations within the services, any pointer-down event stop ongoing gesture animation now.
    @josxha
    josxha committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    3fae4e2 View commit details
    Browse the repository at this point in the history

  5. change abtract classes that have no method bodies or fields to interf… 

    …aces
    @josxha
    josxha committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    0b17c54 View commit details
    Browse the repository at this point in the history

  6. Merge pull request #2 add polymorthism to gesture services 

    add polymorthism to gesture services
    @josxha
    josxha committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    ae3ac26 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' into gesture-handling

    @josxha
    josxha committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    777e432 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2024

  1. fix spelling

    @josxha
    josxha committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    57d94db View commit details
    Browse the repository at this point in the history

  2. feat: add support for trackpad zoom gesture (#3) 

    * add trackpad zoom gesture to EnabledGestures, as event and as service

* split both trackpad gestures into two services

* trackpad zoom center on cursor

* rename variable
    @josxha
    josxha committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    be6cefb View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into gesture-handling

    @josxha
    josxha committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    d8c2f12 View commit details
    Browse the repository at this point in the history

  4. match trackpad velocity on new and legacy service

    @josxha
    josxha committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    874b3a9 View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2024

  1. rename EnabledGestures to MapGestures

    @josxha
    josxha committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    e49bc02 View commit details
    Browse the repository at this point in the history

  2. remove hasMultiFinger() method 

    Removed this method because it was only used in MapInteractiveViewer.updateGestures and could cause confusion between multi point touchscreen and mutli point trackpad gestures.
    @josxha
    josxha committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    e175fcf View commit details
    Browse the repository at this point in the history

  3. update docs

    @josxha
    josxha committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    7d7b539 View commit details
    Browse the repository at this point in the history

  4. rename multiFinger to twoFinger to match the gesture services

    @josxha
    josxha committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    53af338 View commit details
    Browse the repository at this point in the history

  5. MapGestures: remove noRotation(), add .noGroups and .allGroups()

    @josxha
    josxha committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    8265953 View commit details
    Browse the repository at this point in the history

  6. change to noneByGroup, allByGroup

    @josxha
    josxha committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    51fa616 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' into gesture-handling

    @josxha
    josxha committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    133d5b8 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'master' into gesture-handling

    @josxha
    josxha committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    c18170b View commit details
    Browse the repository at this point in the history

  9. additional changes to merge upstream

    @josxha
    josxha committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    bacd10d View commit details
    Browse the repository at this point in the history

  10. add documentation

    @josxha
    josxha committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    bcf30c5 View commit details
    Browse the repository at this point in the history

  11. add trackpadZoom to example app

    @josxha
    josxha committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    6155f3a View commit details
    Browse the repository at this point in the history

  12. fix overflow in example app

    @josxha
    josxha committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    e8d4577 View commit details
    Browse the repository at this point in the history