Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update blogmaker instructions and deploy settings #132

Merged
merged 3 commits into from
Sep 26, 2024

Conversation

davidlfox
Copy link
Contributor

Why?

instructions didnt work in their current order. publish.py expected [domain] to have a value and vitalik's repo doesnt have that value in config.md

also, the build command setting was off by a * (to deploy to fleek)

How?

  • read the post
  • figured out why the steps were busted
  • fixed it

Tickets?

  • tell me how to create a ticket and i will :)

Contribution checklist?

  • The commit messages are detailed
  • The build command runs locally
  • Assets or static content are linked and stored in the project
  • Document filename is named after the slug
  • You've reviewed spelling using a grammar checker
  • For documentation, guides or references, you've tested the commands and steps
  • You've done enough research before writing

Security checklist?

  • Sensitive data has been identified and is being protected properly
  • Injection has been prevented (parameterized queries, no eval or system calls)
  • The Components are escaping output (to prevent XSS)

References?

Optionally, provide references such as links

Preview?

Optionally, provide the preview url here

Copy link

changeset-bot bot commented Aug 12, 2024

⚠️ No Changeset found

Latest commit: 1608374

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@davidlfox davidlfox force-pushed the docs/fix-blogmaker-instructions branch 2 times, most recently from 76e622c to d2c8f16 Compare August 13, 2024 21:05
@nlc616 nlc616 requested review from heldrida and KanishkKhurana and removed request for heldrida August 14, 2024 22:09
@gabrielmpinto gabrielmpinto requested review from nlc616 and a team August 23, 2024 10:35
@davidlfox davidlfox force-pushed the docs/fix-blogmaker-instructions branch from 31fd2e4 to 57d01bf Compare August 27, 2024 12:46
@davidlfox davidlfox force-pushed the docs/fix-blogmaker-instructions branch from 57d01bf to 280eeaf Compare August 27, 2024 14:37
Copy link
Contributor

@KanishkKhurana KanishkKhurana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nlc616 nlc616 merged commit 6c1a15d into develop Sep 26, 2024
5 checks passed
@nlc616 nlc616 deleted the docs/fix-blogmaker-instructions branch September 26, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants