Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 🧹 adds link to 'lose customers' text on landing page, fixes typo on FF blog #14

Merged
merged 9 commits into from
Jun 10, 2024

Conversation

nlc616
Copy link
Contributor

@nlc616 nlc616 commented Jun 8, 2024

Why?

Adds link to performance blog from 'lose customers' text on landing page.

How?

  • Done A (replace with a breakdown of the steps)
  • Done B
  • Done C

Tickets?

Contribution checklist?

  • The commit messages are detailed
  • The build command runs locally
  • Assets or static content are linked and stored in the project
  • Document filename is named after the slug
  • You've reviewed spelling using a grammar checker
  • For documentation, guides or references, you've tested the commands and steps
  • You've done enough research before writing

Security checklist?

  • Sensitive data has been identified and is being protected properly
  • Injection has been prevented (parameterized queries, no eval or system calls)
  • The Components are escaping output (to prevent XSS)

References?

Optionally, provide references such as links

Preview?

Optionally, provide the preview url here

@nlc616
Copy link
Contributor Author

nlc616 commented Jun 8, 2024

@KanishkKhurana If possible before merging this in can you pull the branch locally to make sure it looks OK? We don't have any other in-paragraph links on the landing page so I want to make sure this isn't wonky, but I'm not going to have my local repo set up until tomorrow and I can't see it easily in the GitHub interface.

@nlc616 nlc616 changed the title chore: 🧹 adds link to 'lose customers' text on landing page chore: 🧹 adds link to 'lose customers' text on landing page, fixes typo on FF blog Jun 9, 2024
@KanishkKhurana
Copy link
Contributor

@KanishkKhurana If possible before merging this in can you pull the branch locally to make sure it looks OK? We don't have any other in-paragraph links on the landing page so I want to make sure this isn't wonky, but I'm not going to have my local repo set up until tomorrow and I can't see it easily in the GitHub interface.

yes cloning and running locally

@KanishkKhurana
Copy link
Contributor

@KanishkKhurana If possible before merging this in can you pull the branch locally to make sure it looks OK? We don't have any other in-paragraph links on the landing page so I want to make sure this isn't wonky, but I'm not going to have my local repo set up until tomorrow and I can't see it easily in the GitHub interface.

yes cloning and running locally

Screen.Recording.2024-06-10.at.10.48.40.PM.mov

KanishkKhurana
KanishkKhurana previously approved these changes Jun 10, 2024
@nlc616 nlc616 merged commit 5fa2d79 into develop Jun 10, 2024
6 checks passed
@nlc616 nlc616 deleted the chore/add-lose-customers-link branch June 10, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants