Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update page titles #220

Merged
merged 5 commits into from
Sep 16, 2024
Merged

feat: update page titles #220

merged 5 commits into from
Sep 16, 2024

Conversation

tobySolutions
Copy link
Member

Why?

Update page titles across the website to include the "Fleek |" prefix before the page titles. I also updated the logic for the path matching to render the secondary navigation as it was just picking whole slugs and matching the words directly.

How?

  • Made updates in BaseHtml.astro with the titles updates
  • Update the hasSecondaryMenuItem function

Tickets?

Contribution checklist?

  • The commit messages are detailed
  • The build command runs locally
  • Assets or static content are linked and stored in the project
  • Document filename is named after the slug
  • You've reviewed spelling using a grammar checker
  • For documentation, guides or references, you've tested the commands and steps
  • You've done enough research before writing

Security checklist?

  • Sensitive data has been identified and is being protected properly
  • Injection has been prevented (parameterized queries, no eval or system calls)
  • The Components are escaping output (to prevent XSS)

Copy link

changeset-bot bot commented Sep 16, 2024

⚠️ No Changeset found

Latest commit: cb411dc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tobySolutions tobySolutions merged commit c0ab35a into develop Sep 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants