Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: 📝 Include migration steps for Fleek.co's CLI #225 #226

Merged
merged 11 commits into from
Sep 27, 2024

Conversation

heldrida
Copy link
Member

@heldrida heldrida commented Sep 17, 2024

Why?

Include migration steps for Fleek.co's CLI.

How?

  • Update CLI Overview page, including the migration steps

Tickets?

Contribution checklist?

  • The commit messages are detailed
  • The build command runs locally
  • Assets or static content are linked and stored in the project
  • Document filename is named after the slug
  • You've reviewed spelling using a grammar checker
  • For documentation, guides or references, you've tested the commands and steps
  • You've done enough research before writing

Security checklist?

  • Sensitive data has been identified and is being protected properly
  • Injection has been prevented (parameterized queries, no eval or system calls)
  • The Components are escaping output (to prevent XSS)

References?

Optionally, provide references such as links

Preview?

Optionally, provide the preview url here

Copy link

changeset-bot bot commented Sep 17, 2024

⚠️ No Changeset found

Latest commit: 154456d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@heldrida heldrida marked this pull request as ready for review September 17, 2024 10:52
Copy link
Contributor

@nlc616 nlc616 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nlc616
Copy link
Contributor

nlc616 commented Sep 26, 2024

@heldrida I'm getting some missing module errors on this PR - can you take a look?
Screenshot 2024-09-26 at 4 39 50 PM
errors

Copy link
Contributor

@nlc616 nlc616 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment about missing modules

@heldrida
Copy link
Member Author

@heldrida I'm getting some missing module errors on this PR - can you take a look? Screenshot 2024-09-26 at 4 39 50 PM errors

@nlc616 I can see that you have merged latest changes from the main branch. The main branch has changes, e.g. new packages. If you are running this branch locally, you should know that you have to update local dependencies.

npm i

@nlc616 nlc616 merged commit bd6add9 into develop Sep 27, 2024
5 checks passed
@nlc616 nlc616 deleted the docs/cli-migrating-from-fleek-co-to-xyz branch September 27, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants