to RC: UI – 2 small unreleased bug fixes for software install policy automat… #22182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions UI (#22181) ## 2 small fixes for issues found in QA - Capitalize word in tooltip - Correctly render error message, with correctly colored icon - [x] Manual QA for all new/changed functionality --------- Co-authored-by: Jacob Shandling <[email protected]>
jacobshandling
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## minor-fleet-v4.57.0 #22182 +/- ##
======================================================
Coverage ? 65.34%
======================================================
Files ? 1493
Lines ? 116623
Branches ? 3543
======================================================
Hits ? 76206
Misses ? 33301
Partials ? 7116
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
RachelElysia
approved these changes
Sep 17, 2024
This was referenced Oct 4, 2024
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR already merged to
main, see #22181. This is against the release branch so it can be included in 4.57.0 (issue #19551)