Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API design: #22075 Option to automatically migrate Windows workstations #22288

Open
wants to merge 35 commits into
base: docs-v4.59.0
Choose a base branch
from
Open

API design: #22075 Option to automatically migrate Windows workstations #22288

wants to merge 35 commits into from
+19,532 −3,861

Conversation

rachaelshaw
Copy link
Member

iansltx and others added 30 commits September 17, 2024 15:21
@iansltx
Use previous package filename for activity if installer edit doesn't …
518a4a1 
…change the package (#22177)

Also adds a line in the makefile help for generate-doc, as it took me
way too long to find that command this time.

# Checklist for submitter

- [x] Manual QA for all new/changed functionality
@jacobshandling
UI – 2 small unreleased bug fixes for software install policy automat…
f135d5b 
…ions UI (#22181)

## 2 small fixes for issues found in QA

- Capitalize word in tooltip
- Correctly render error message, with correctly colored icon

- [x] Manual QA for all new/changed functionality

---------

Co-authored-by: Jacob Shandling <[email protected]>
@roperzh
Allow CA certificates with extendedKeyUsage attributes. (#22160)
2bfbf2f
@sharon-fdm
Add CIS policy for tests (#22112)
b11edd9
@getvictor
Updated PS1 install/uninstall scripts to fail on error. (#22164)
ddbdce4
@eashaw
Website: add default organization to Premium trial license keys. (#22192
1f1bc9c 
)

Closes: #22190

Changes:
- updated `save-questionnaire-progress` to set a default value for the
`organization` value of generated license keys (if a user does not have
an organization set)
@iansltx
Ensure edited scripts provided from the client with newline switches …
ea2a978 
…and no other changes get converted to "\n" (#22196) (#22199)

# Checklist for submitter

- [x] Manual QA for all new/changed functionality
@iansltx
Pass through uninstall error messages from backend (#22208)
f7fab00 
# Checklist for submitter

- [x] Manual QA for all new/changed functionality

[See
Slack](https://fleetdm.slack.com/archives/C01EZVBHFHU/p1726605318985819?thread_ts=1726588126.583269&cid=C01EZVBHFHU)
from @noahtalerman for context
@jacobshandling
UI: handle possibly 'null' 'storedPolicy.team_id' on update policy ca…
4ee79ae 
…ll (#22215)

## #22145 


![ezgif-2-c62195a3ba](https://github.com/user-attachments/assets/4db3fcf8-f706-40e5-a1e5-c422ff7ac6c6)

- [x] Changes file added for user-visible changes in `changes/`
- [x] Manual QA for all new/changed functionality

Co-authored-by: Jacob Shandling <[email protected]>
@lucasmrod
Fixes for no-team.yml GitOps (#22210)
90959db 
#22185

- [X] Manual QA for all new/changed functionality
@ghernandez345 @gillespi314 @roperzh
Update tooltip for mac minimum target OS version label (#22157)
36ea5cc 
Co-authored-by: gillespi314 <[email protected]>
Co-authored-by: Roberto Dip <[email protected]>
@eashaw
Website: Add search and breadcrumbs to article template page (#22171)
721ed30 
Closes: #15857
Closes: #21850

Changes:
- Updated the article page template to include a search input and
breadcrumb links.
@ghernandez345
show correct chrome software icon for chrome packages (#22233)
9a1b376 
relates to #20865

Show the correct software icon for uploaded chrome packages


![image](https://github.com/user-attachments/assets/85215a31-0b63-438b-a4dc-661cea026c3b)

- [x] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
- [x] Manual QA for all new/changed functionality
@eashaw
Website: Deliver contact form messages to Slack (#22231)
ebb62af 
Related to: fleetdm/confidential#8098

Changes:
- Updated `deliver-contact-form-message` to send contact form
submissions to a Slack webhook.
@mikermcneil
Iron out the nav -- Update layout.ejs (#22151)
246fa60
@mikermcneil @eashaw
Update link + CTA on pricing.ejs (#22229)
6ab05de 
Co-authored-by: Eric <[email protected]>
@eashaw
Website: Update start CTA orb image (psyStage 4) (#22232)
ad4c05e 
Changes:
- Updated the /start CTA image for psystage 4 users
@jahzielv
fix: stop profiles that never reached the host from showing up as fai…
90c04ee 
…led (#22186)

> Related issue: #21891

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

<!-- Note that API documentation changes are now addressed by the
product design team. -->

- [x] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files)
for more information.
- [x] Added/updated tests
- [x] Manual QA for all new/changed functionality
@lukeheath @Sampfluger88
Document 0-day macOS major version support process beginning with mac…
e2ac27e 
…OS 16 (#22243)

Co-authored-by: Sam Pfluger <[email protected]>
@mikermcneil
Update link, clarify iOS (#22230)
d52335e
@Sampfluger88
Add template response to hiring steps (#22255)
f247e57
@Sampfluger88
Remove AE position (#22256)
edec764
@noahtalerman @eashaw
fleetdm.com/start: suggested copy change for fleetctl install (#22251)
07a5826 
- Suggesting capital "Linux" and "macOS" b/c it feels more official.

---------

Co-authored-by: Eric <[email protected]>
@noahtalerman @Sampfluger88
Add Product Designer position (#22250)
2a88d5a 
Co-authored-by: Sam Pfluger <[email protected]>
@noahtalerman
Update pricing-features-table.yml (#22235)
e4b6fae 
- ACME in 2025
@RachelElysia
Fleet UI: Fix observer persisting host_id when querying host from hos…
2708988 
…t details page (#22249)
@lucasmrod
Make software batch endpoint asynchronous (#22258)
8d664bd 
#22069

API changes: #22259

QAd by applying 10 pieces of software on a team, which took 3+ minutes
in total (which, before these changes was timing out at 100s.)

With this approach, a GitOps CI run timing out might leave the
background process running (which will eventually be applied to the
database). The team discussed and agreed that we can fix this edge case
later.

- [X] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files)
for more information.
- [X] Input data is properly validated, `SELECT *` is avoided, SQL
injection is prevented (using placeholders for values in statements)
- [X] Added/updated tests
- [X] Manual QA for all new/changed functionality
@nonpunctual
Update discovering-chrome-ai-using-fleet.md (#22268)
92d3b70 
It's 1 letter. I waited days to do this. :)
@noahtalerman
Dogfood: remove "Explore data (fleetdm.com)" team (#22246)
eeb0579
@noahtalerman @mna
@dantecatalfamo @marko-lisica @georgekarrv @ghernandez345 @rachaelshaw
GitOps & API design: Add multiple Apple Business Manager and Volume P…
1677783 
…urchasing Program connections (#21043)

GitOps and API changes for the following story:
- #9956

DONE: 
- ~~Contributor API endpoints to support best practice GitOps (`fleetctl
gitops`) and backwards compatibility GitOps (`fleetctl apply`)~~
  - #21043 (comment)

---------

Co-authored-by: Martin Angers <[email protected]>
Co-authored-by: Dante Catalfamo <[email protected]>
Co-authored-by: Marko Lisica <[email protected]>
Co-authored-by: George Karr <[email protected]>
Co-authored-by: Gabriel Hernandez <[email protected]>
Co-authored-by: Rachael Shaw <[email protected]>
jahzielv and others added 5 commits September 20, 2024 15:39
@jahzielv @spokanemac @noahtalerman
feat: update MDM migration guide with new UX (#22128)
84473c2 
> Related issue: #22097

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

<!-- Note that API documentation changes are now addressed by the
product design team. -->

- [x] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files)
for more information.
- [x] Manual QA for all new/changed functionality

---------

Co-authored-by: spokanemac <[email protected]>
Co-authored-by: Noah Talerman <[email protected]>
Co-authored-by: Noah Talerman <[email protected]>
Co-authored-by: JD <[email protected]>
@rebeccaui
Update button name in deploy-fleet.md (#22271)
a17ab39 
Render changed their "Apply" button to read "Deploy Blueprint"
@noahtalerman @RachelElysia
Remove placeholder text (#22274)
fc8b1d6 
---------

Co-authored-by: RachelElysia <[email protected]>
@RachelElysia
Fleet UI: Disable install/uninstall actions if scripts are disabled (#…
d7594d1 
…22240)
@rachaelshaw
Update rest-api.md
ff62f98
@codecov Codecov
Copy link

codecov bot commented Sep 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 64.00000% with 108 lines in your changes missing coverage. Please review.

Project coverage is 55.72%. Comparing base (b111011) to head (ff62f98).
Report is 1 commits behind head on docs-v4.59.0.

Files with missing lines Patch % Lines
ee/server/service/software_installers.go 60.13% 43 Missing and 14 partials ⚠️
...end/pages/hosts/details/cards/Software/helpers.tsx 27.77% 13 Missing ⚠️
server/service/software_installers.go 61.11% 6 Missing and 1 partial ⚠️
server/service/redis_key_value/redis_key_value.go 64.70% 4 Missing and 2 partials ⚠️
server/service/client_software.go 75.00% 3 Missing and 2 partials ⚠️
frontend/router/paths.ts 0.00% 4 Missing ⚠️
server/datastore/mysql/software_installers.go 82.35% 2 Missing and 1 partial ⚠️
cmd/fleetctl/gitops.go 77.77% 1 Missing and 1 partial ⚠️
...ages/hosts/details/cards/Software/HostSoftware.tsx 0.00% 2 Missing ⚠️
pkg/spec/gitops.go 66.66% 1 Missing and 1 partial ⚠️
... and 6 more
Additional details and impacted files 
@@               Coverage Diff                @@
##           docs-v4.59.0   #22288      +/-   ##
================================================
- Coverage         65.19%   55.72%   -9.48%     
================================================
  Files              1495     1496       +1     
  Lines            117084   117247     +163     
  Branches           3555     3514      -41     
================================================
- Hits              76336    65338   -10998     
- Misses            33624    45631   +12007     
+ Partials           7124     6278     -846
Flag Coverage Δ
backend 55.94% <65.75%> (-10.54%) ⬇️
frontend 52.35% <53.48%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sampfluger88 Sampfluger88 Awaiting requested review from Sampfluger88 Sampfluger88 is a code owner

@lukeheath lukeheath Awaiting requested review from lukeheath lukeheath is a code owner

@mikermcneil mikermcneil Awaiting requested review from mikermcneil mikermcneil is a code owner

@noahtalerman noahtalerman Awaiting requested review from noahtalerman noahtalerman is a code owner

@spokanemac spokanemac Awaiting requested review from spokanemac spokanemac is a code owner

@getvictor getvictor Awaiting requested review from getvictor getvictor is a code owner

@eashaw eashaw Awaiting requested review from eashaw

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.