add missing template instantiation for conservativeAdvancement #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now partial template instantiation are available for RSS/OBBRSS which resemble the situation of 0.5.0 where MeshConservativeAdvancementTraversalNodeRSS/OBBRSS are used and not MeshConservativeAdvancementTraversalNode The later refitting the whole tree, while the former two only work with transformations locally stored in the node. Refactors code to avoid duplication resolves flexible-collision-library#297
|
I'll check with other compilers .... |
|
It seems it's a VS2015 problem .... can somebody check with a newer version of VS? |
|
Or can somebody add a workaround on top of my commit? Fact is that the current |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now partial template instantiation are available for RSS/OBBRSS
which resemble the situation of 0.5.0 where
MeshConservativeAdvancementTraversalNodeRSS/OBBRSSare used and notMeshConservativeAdvancementTraversalNodeThe later refitting the whole tree, while the former two only work with
transformations locally stored in the node.
Refactors code to avoid duplication
resolves #297
Couldn't find a test to adapt
This change is