Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace non-portable M_PI with constants::pi() #553

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Replace non-portable M_PI with constants::pi() #553

wants to merge 2 commits into from

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Nov 13, 2021 •
edited
Loading

Similar to:

Problem originally experienced in conda-forge/fcl-feedstock#11, but it seems it was also experienced in #546 .

This change is Reviewable

@traversaro traversaro mentioned this pull request Nov 13, 2021
Merged
5 tasks
@traversaro
Copy link
Contributor Author

traversaro commented Nov 13, 2021 •
edited
Loading

I am not sure why the problem was not detected in CI, I guess #389 or something similar issue like #442 . If there is interest in the fcl mantainers I would be happy to contribute and mantain a GitHub Actions-based CI script, either using conda-forge or vcpkg dependencies.

@sherm1
Copy link
Member

sherm1 commented Dec 21, 2021

@traversaro I see CI is not triggering for this and other PRs. Any thoughts on how to fix?

@traversaro
Copy link
Contributor Author

@traversaro I see CI is not triggering for this and other PRs. Any thoughts on how to fix?

I am not sure. Perhaps it is the mitigation against mining for which mantainers need to manually allow CI jobs from PRs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@traversaro @sherm1