add unit-test workflow #606
Conversation
|
we might think about disabling the test-run for 8.4 for now, as the problems come from external dependencies |
| @@ -68,6 +68,8 @@ public function testControllerAlreadyExists() | |||
|
|
|||
| public function testCreateController() | |||
| { | |||
|
|
|||
| $this->markTestIncomplete('does not work on php > 8.0'); | |||
There was a problem hiding this comment.
I wonder why this one doesn't work. I've been able to run php8.3 unit tests on this without any problem...I wonder wonder why it gave you problems.
There was a problem hiding this comment.
I even went to my core code, removed my vendor dir, installed everything with php8.2 and my tests still pass.
There was a problem hiding this comment.
actually i am not sure if it is really a php8 problem
but steps to reproduce should be to complety remove the vendor dir and composer.lock, make sure the dependency for nette/php-generator is not in composer.json, then do a composer install and run the test again
There was a problem hiding this comment.
aha, have to also delete the composer.lock directory. Got it!
this adds a github workflow that runs the unit tests against all php versions from 7.4 up to 8.4 on all pull requests