Fix recursive bug in fq_default_ctx_init_modulus_type #1930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a test case? |
Yes! I will just check that this indeed fixes the bug. |
albinahlback
force-pushed
the
fix_fq_default_ctx
branch
from
f1873a8
to
e2cc686
Compare
|
Added the tests and found another bug. |
albinahlback
force-pushed
the
fix_fq_default_ctx
branch
2 times, most recently
from
90040ec
to
02cb84d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this is the source of the bug Tommy described in Nemocas/Nemo.jl#1568