Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add styling to JSON animation #6
base: master
Are you sure you want to change the base?
Add styling to JSON animation #6
Changes from all commits
5e50562
55f98fd
199780a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we have already passed the styles to BaseAnimationWrapper, do we still need to explicitly pass it to this container as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, looks fishy, will have to test this. I will check this and then update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@swapnil1104 We are using RLV, which requires all its parent element to have fixed height or flex.
That's why the style prop is passed to container also.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are consuming
StyleProp<ViewStyles>
and not just a height value, that would mean any other additional style will also be applied to bothBaseAnimationWrapper
andJsonAnimationWrapper
.Have we verified that this won't cause any side-effects, by passing styles other than flex and fixed height to this prop?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then we can pass different styleProps to
BaseAnimationWrapper
andJsonAnimationWrapper
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you verify the repercussions of sending the same style to the containers?
We can send different style props to the different containers, but that will pollute the public API of AnimationWrapperView, should carefully consider before adding additional props just to satisfy one condition.
We can explore extracting only height out of the style props and pass it to the JsonAnimationWrapper.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@swapnil1104 created new PR for this: https://github.com/flipkart-incubator/animation-wrapper-view/pull/7/files