Skip to content

Commit

Permalink
Bump Guice & Fix Runtime Issues on Java21 (#56)
Browse files Browse the repository at this point in the history
Fix runtime issues on java21
  • Loading branch information
kingster authored Jan 23, 2024
1 parent 5848b0d commit 58972ea
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 6 deletions.
4 changes: 3 additions & 1 deletion build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ publishing {

def grpcVersion = '1.38.0'
def jacksonVersion = '2.9.7'
def guiceVersion = '4.1.0'
def guiceVersion = '5.1.0'

subprojects {
group = 'com.flipkart.grpc-jexpress'
Expand All @@ -66,6 +66,8 @@ subprojects {
log4j_slf4j : "org.apache.logging.log4j:log4j-slf4j-impl:2.5",
commons_configuration : "commons-configuration:commons-configuration:1.10",
guice : "com.google.inject:guice:${guiceVersion}",
guava : 'com.google.guava:guava:30.1-jre',
jaxb_api : 'javax.xml.bind:jaxb-api:2.3.1',
dw_metrics : "com.palominolabs.metrics:metrics-guice:5.0.1",
dw_metrics_healthchecks : "io.dropwizard.metrics5:metrics-healthchecks:5.0.0",
dw_metrics_annotation : "io.dropwizard.metrics5:metrics-annotation:5.0.0",
Expand Down
17 changes: 12 additions & 5 deletions examples/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,16 @@ def protobufVersion = '3.12.0'
def protocVersion = protobufVersion

dependencies {
implementation "com.flipkart.grpc-jexpress:core:${jexpressVersion}"
implementation "com.flipkart.grpc-jexpress:runtime:${jexpressVersion}"
implementation "com.flipkart.grpc-jexpress:guice:${jexpressVersion}"
//For Development
implementation project(':core')
implementation project(':runtime')
implementation project(':guice')

// In actual
// implementation "com.flipkart.grpc-jexpress:core:${jexpressVersion}"
// implementation "com.flipkart.grpc-jexpress:runtime:${jexpressVersion}"
// implementation "com.flipkart.grpc-jexpress:guice:${jexpressVersion}"

implementation "io.grpc:grpc-netty-shaded:${grpcVersion}"
implementation "io.grpc:grpc-protobuf:${grpcVersion}"
implementation "io.grpc:grpc-stub:${grpcVersion}"
Expand Down Expand Up @@ -69,7 +76,7 @@ sourceSets {
startScripts.enabled = false

task helloWorldServer(type: CreateStartScripts) {
mainClassName = 'com.flipkart.gjex.examples.helloworld.HelloWorldApplication'
mainClass = 'com.flipkart.gjex.examples.helloworld.HelloWorldApplication'
applicationName = 'hello-world-server'
outputDir = new File(project.buildDir, 'tmp')
classpath = startScripts.classpath
Expand All @@ -86,7 +93,7 @@ task runHelloWorldServer(type: JavaExec) {


task helloWorldClient(type: CreateStartScripts) {
mainClassName = 'com.flipkart.gjex.examples.helloworld.client.HelloWorldClient'
mainClass = 'com.flipkart.gjex.examples.helloworld.client.HelloWorldClient'
applicationName = 'hello-world-client'
outputDir = new File(project.buildDir, 'tmp')
classpath = startScripts.classpath
Expand Down
2 changes: 2 additions & 0 deletions guice/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ dependencies {
implementation project(':core')
implementation libraries.commons_configuration
implementation libraries.guice
implementation libraries.guava
implementation libraries.jaxb_api
implementation libraries.dw_metrics
implementation libraries.dw_metrics_healthchecks
implementation libraries.dw_metrics_annotation
Expand Down

0 comments on commit 58972ea

Please sign in to comment.