Allow modifications from http-filters

flipkart-incubator · Aug 9, 2024 · fc7843b · fc7843b
1 parent 22e48de
commit fc7843b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/...es/src/main/java/com/flipkart/gjex/examples/helloworld/filter/CustomHeaderHttpFilter.java b/...es/src/main/java/com/flipkart/gjex/examples/helloworld/filter/CustomHeaderHttpFilter.java
@@ -20,13 +20,14 @@ public void doProcessRequest(ServletRequest servletRequest, RequestParams<Map<St
     @Override
     public void doProcessResponseHeaders(Map<String, String> responseHeaders) {
         super.doProcessResponseHeaders(responseHeaders);
+        responseHeaders.put("x-custom-doProcessResponseHeaders", "custom-header-value");
     }
 
     @Override
     public void doProcessResponse(ServletResponse response) {
         super.doProcessResponse(response);
         HttpServletResponse httpServletResponse = (HttpServletResponse) response;
-        httpServletResponse.addHeader("x-custom-header", "custom-header-value");
+        httpServletResponse.addHeader("x-custom-doProcessResponse", "custom-header-value");
     }
 
     @Override

diff --git a/guice/src/main/java/com/flipkart/gjex/http/interceptor/HttpFilterInterceptor.java b/guice/src/main/java/com/flipkart/gjex/http/interceptor/HttpFilterInterceptor.java
@@ -85,11 +85,14 @@ public final void doFilter(ServletRequest request, ServletResponse response,
             try {
                 filters.forEach(filter -> filter.doProcessRequest(request, requestParams));
                 chain.doFilter(request, responseWrapper);
+
+                // Allow the filters to process the response headers
                 Map<String, String> responseHeaders = responseWrapper.getHeaderNames()
                     .stream().collect(Collectors.toMap(h -> h, httpServletResponse::getHeader));
                 filters.forEach(filter -> filter.doProcessResponseHeaders(responseHeaders));
-
+                responseHeaders.forEach(responseWrapper::setHeader);
             } finally {
+                // Allow the filters to process the response
                 filters.forEach(filter -> filter.doProcessResponse(responseWrapper));
                 response.getOutputStream().write(responseWrapper.getWrapperBytes());
             }