Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correcting request time in http access logs #102

Merged
merged 13 commits into from
Aug 21, 2024
Merged

Correcting request time in http access logs #102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
d40fe94
added error handling
ajay-jalgaonkar Aug 16, 2024
fb8e466
added error handling for http access logs
ajaypj Aug 16, 2024
d7d3e55
setting -1
ajaypj Aug 16, 2024
2dd8615
import
ajaypj Aug 16, 2024
5b79dc6
calls
ajaypj Aug 17, 2024
79a8105
calls
ajaypj Aug 17, 2024
2701b8a
changes
ajay-jalgaonkar Aug 20, 2024
3028e66
starttime
ajay-jalgaonkar Aug 20, 2024
9cde585
changes from master
ajay-jalgaonkar Aug 20, 2024
03c4214
changes from master
ajay-jalgaonkar Aug 20, 2024
b2720b5
Merge branch 'master' of github.com:flipkart-incubator/grpc-jexpress …
ajay-jalgaonkar Aug 20, 2024
c10c69a
setting start time
ajay-jalgaonkar Aug 20, 2024
89bff11
fixed requesttime
ajay-jalgaonkar Aug 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion core/src/main/java/com/flipkart/gjex/core/filter/grpc/AccessLogGrpcFilter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,8 @@ public class AccessLogGrpcFilter<R extends GeneratedMessageV3, S extends Generat

public AccessLogGrpcFilter() {
accessLogContextBuilder = AccessLogContext.builder();
accessLogContextBuilder.requestTime(System.currentTimeMillis());
startTime = System.currentTimeMillis();
accessLogContextBuilder.requestTime(startTime);
}

/**
Expand Down
3 changes: 2 additions & 1 deletion core/src/main/java/com/flipkart/gjex/core/filter/http/AccessLogHttpFilter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,8 @@ public class AccessLogHttpFilter extends HttpFilter implements Logging {

public AccessLogHttpFilter() {
accessLogContextBuilder = AccessLogContext.builder();
accessLogContextBuilder.requestTime(System.currentTimeMillis());
startTime = System.currentTimeMillis();
accessLogContextBuilder.requestTime(startTime);
}

public static void setFormat(String format) {
Expand Down