Merge pull request #102 from deefreak/ossbug

Nil check for replica count for rollout and deployment client
flipkart-incubator · Jan 12, 2024 · 7beece4 · 7beece4
2 parents f7934b1 + ebd7934
commit 7beece4
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/pkg/registry/deployment_client.go b/pkg/registry/deployment_client.go
@@ -107,6 +107,9 @@ func (dc *DeploymentClient) GetReplicaCount(namespace string, name string) (int,
 	if err := dc.k8sClient.Get(context.Background(), types.NamespacedName{Namespace: namespace, Name: name}, deploymentObject); err != nil {
 		return 0, err
 	}
+	if deploymentObject.Spec.Replicas == nil {
+		return 0, fmt.Errorf("replica count not present")
+	}
 	return int(*deploymentObject.Spec.Replicas), nil
 }
 

diff --git a/pkg/registry/rollout_client.go b/pkg/registry/rollout_client.go
@@ -107,6 +107,9 @@ func (rc *RolloutClient) GetReplicaCount(namespace string, name string) (int, er
 	if err := rc.k8sClient.Get(context.Background(), types.NamespacedName{Namespace: namespace, Name: name}, rolloutObject); err != nil {
 		return 0, err
 	}
+	if rolloutObject.Spec.Replicas == nil  {
+		return 0, fmt.Errorf("replica count not present")
+	}
 	return int(*rolloutObject.Spec.Replicas), nil
 }