Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grouped + UnGrouped message src PR feedback changes #143

Merged
merged 4 commits into from
May 22, 2024
Merged

Grouped + UnGrouped message src PR feedback changes #143

merged 4 commits into from
May 22, 2024

Conversation

aayustark007-fk
Copy link
Collaborator

  • Fix maxInflight conditional.
  • Replace supplyAsync with completedFuture for non-blocking flows.
  • Refactor iterator code in ungrouped src to reduce code duplication.

gauravAshok
gauravAshok approved these changes May 22, 2024
View reviewed changes
Copy link
Collaborator

@gauravAshok gauravAshok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link

Test Results

218 tests   218 ✅  44s ⏱️
 50 suites    0 💤
 50 files      0 ❌

Results for commit f80901b.

@aayustark007-fk aayustark007-fk merged commit 1e89b2c into master May 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gauravAshok gauravAshok gauravAshok approved these changes

@kmrdhruv kmrdhruv Awaiting requested review from kmrdhruv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aayustark007-fk @gauravAshok @AayuStark007