making fixes to grouped message src, so that nextMessages always retu… #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rns with messages asynchronously. previously it could return with 0 msgs and used to prioritize fetching messages from consumer
…one on consumer thread only.
gauravAshok
commented
May 24, 2024
| @@ -158,7 +214,7 @@ private void free(String groupId, MessageConsumptionStatus status) { | |||
| throw new IllegalStateException(String.format("Tried to free group %s: %s", gId, tracker)); | |||
| } | |||
| var messages = tracker.messages; | |||
| if (!messages.isEmpty() && messages.getFirst().remaining() == 0) { | |||
There was a problem hiding this comment.
using while to make sure that messages batch with empty entries are not going to be put back in the hashmap.
gauravAshok
commented
May 24, 2024
| return replenishAvailableGroups().thenApply(v -> nextMessagesInternal(messages)); | ||
| int count = nextMessagesInternal(messages); | ||
| if (count > 0) { | ||
| return CompletableFuture.completedFuture(count); |
There was a problem hiding this comment.
prioritizing the array filling.
If no message present / no free group present. try to fetch fresh messages.
And this is the difference, There are 2 conditions, which can unblock the "array filling". the fetch returning with new messages.
and the group getting freed up.
gauravAshok
commented
May 24, 2024
| private void tryCompletePendingRequest() { | ||
| NextMsgsRequest request; | ||
| if ((request = pendingRequest.getAndSet(null)) != null) { | ||
| request.result.complete(nextMessagesInternal(request.messages)); |
There was a problem hiding this comment.
there is still a chance, where we still end up completing the request with 0 messages, but this should be much rarer now.
aayustark007-fk
approved these changes
May 24, 2024
aayustark007-fk
pushed a commit
that referenced
this pull request
Jun 7, 2024
#145) Making fixes to grouped message src, so that nextMessages always returns with messages asynchronously. previously it could return with 0 msgs and used to prioritize fetching messages from consumer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rns with messages asynchronously. previously it could return with 0 msgs and used to prioritize fetching messages from consumer