Retry for failed operation #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- message channel PR comments
…ution and updates on subscription operation for a subscription
…criptions. This includes - main sub, retry topic & sub, dlt topic & sub - basic shard/partitioning based on qps/throughput limits - subscription running status controller API - subscription provisioning status in rest API Moved internal queue type and topic partition related entities to entities module.
- Add active produce/consume topic/subscription to composite entities - Move default topic/node capacity to config from hard coded values. - moved varadhitopic factory/service to server module. - refactoring related to start subscription in consumer
Test Results280 tests 280 ✅ 59s ⏱️ Results for commit c3858ff. ♻️ This comment has been updated with latest results. |
AayuStark007
requested changes
Aug 1, 2024
| import lombok.AllArgsConstructor; | ||
|
|
||
| @AllArgsConstructor | ||
| public class RetryPolicy { |
There was a problem hiding this comment.
can use builder with defaults here to allow easy construction of the instance
There was a problem hiding this comment.
Not doing this for now as not sure of final policy struct, also policy is created only once in code (excluding test). Would prefer to avoid test defaults in prod code.
entities/src/main/java/com/flipkart/varadhi/entities/cluster/ShardStatus.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation of retry failed operation in controller. Retry is based on simple retry policy and will always be attempted. Currently retry is failure agnostic.
TODO:: working on tests.