Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use address for remote calls in vertx clustered event bus #165

Merged
merged 4 commits into from
Nov 5, 2024
Merged

Use address for remote calls in vertx clustered event bus #165

merged 4 commits into from
Nov 5, 2024

Conversation

iosdev747
Copy link
Collaborator

@iosdev747 iosdev747 commented Sep 16, 2024 •
edited
Loading

PR changes:

  • HostUtils has to be init before using it in the app/tests. (On init it stores the hostname and address or throws exceptions to fail the startup).
  • To address running app in k8s env, vertx clustered event bus will be using IP address for public comms (over the wire) and hostname for node identification.

gauravAshok
gauravAshok reviewed Oct 18, 2024
View reviewed changes
server/src/main/java/com/flipkart/varadhi/VaradhiApplication.java
@@ -97,6 +98,7 @@ private static Future<Vertx> createClusteredVertx(
EventBusOptions eventBusOptions = new EventBusOptions()
.setHost(memberInfo.hostname())
.setPort(port)
.setClusterPublicHost(memberInfo.address())
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in eventbus options, what is host used for if cluster public host is already present?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

host will be used for nodeId (internal to vertx) but for actual comms, address will be used.

@anuj-flipkart anuj-flipkart linked an issue Oct 24, 2024 that may be closed by this pull request
Use address for remote calls in vertx clustered event bus #176
Closed
@iosdev747 iosdev747 changed the title Add flag based host name/address use Use address for remote calls in vertx clustered event bus Oct 29, 2024
kmrdhruv
kmrdhruv approved these changes Nov 4, 2024
View reviewed changes
Copy link
Collaborator

@kmrdhruv kmrdhruv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iosdev747 iosdev747 merged commit e5e120c into flipkart-incubator:master Nov 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gauravAshok gauravAshok gauravAshok left review comments

@kmrdhruv kmrdhruv kmrdhruv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use address for remote calls in vertx clustered event bus
3 participants
@iosdev747 @gauravAshok @kmrdhruv