-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
otel collector for metric collection. #166
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- message channel PR comments
…ution and updates on subscription operation for a subscription
…criptions. This includes - main sub, retry topic & sub, dlt topic & sub - basic shard/partitioning based on qps/throughput limits - subscription running status controller API - subscription provisioning status in rest API Moved internal queue type and topic partition related entities to entities module.
- Add active produce/consume topic/subscription to composite entities - Move default topic/node capacity to config from hard coded values. - moved varadhitopic factory/service to server module. - refactoring related to start subscription in consumer
Works for dev setup for metric collection. For prod additional changes will be needed. - Convert the otel container as a sidecar - Test traces and logs in addition to metrics. - Promethous configuration for scrapping needs to be defined.
Test Results280 tests 280 ✅ 58s ⏱️ Results for commit c8510b4. ♻️ This comment has been updated with latest results. |
updating job definition due to container rename.
gaurav-ashok
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works for dev setup for metric collection.
For prod additional changes will be needed.