Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otel collector for metric collection. #166

Merged
merged 57 commits into from
Oct 1, 2024
Merged

otel collector for metric collection. #166

merged 57 commits into from
Oct 1, 2024

Conversation

kmrdhruv
Copy link
Collaborator

@kmrdhruv kmrdhruv commented Oct 1, 2024

Works for dev setup for metric collection.

For prod additional changes will be needed.

  • Convert the otel container as a sidecar
  • Test traces and logs in addition to metrics.
  • Promethous configuration for scrapping needs to be defined.

…ution and updates on subscription operation for a subscription
…criptions. This includes

- main sub, retry topic & sub, dlt topic & sub
- basic shard/partitioning based on qps/throughput limits
- subscription running status controller API
- subscription provisioning status in rest API
Moved internal queue type and topic partition related entities to entities module.
- Add active produce/consume topic/subscription to composite entities
- Move default topic/node capacity to config from hard coded values.
- moved varadhitopic factory/service to server module.
- refactoring related to start subscription in consumer
Works for dev setup for metric collection.

For prod additional changes will be needed.
- Convert the otel container as a sidecar
- Test traces and logs in addition to metrics.
- Promethous configuration for scrapping needs to be defined.
@kmrdhruv kmrdhruv changed the title Controller otel collector for metric collection. Oct 1, 2024
Copy link

github-actions bot commented Oct 1, 2024

Test Results

280 tests   280 ✅  58s ⏱️
 55 suites    0 💤
 55 files      0 ❌

Results for commit c8510b4.

♻️ This comment has been updated with latest results.

updating job definition due to container rename.
Copy link

@gaurav-ashok gaurav-ashok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kmrdhruv kmrdhruv merged commit 43a9ac9 into master Oct 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants