Clean up code and return UUID from rollbar response #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simplifies the code by combining the shared logic across functions into a new `reportErrorSWithOptions` that optionally returns a rollbar uuid to help better identify errors. There is further cleanup that could be done but this seemed like a decent place to stop. This is a mildly breaking change (I aligned the arguments to the functions so they match) but largely tries to keep compatibility.
ysangkok
reviewed
Dec 6, 2023
src/Rollbar.hs
Outdated
| , "notifier" | ||
| .= Aeson.object | ||
| [ "name" .= ("rollbar-haskell" :: T.Text) | ||
| , "version" .= ("1.1.3" :: T.Text) |
There was a problem hiding this comment.
might wanna change this now that we're touching all lines
ysangkok
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies the code by combining the shared logic across functions into a new
reportErrorSWithOptionsthat optionally returns a rollbar uuid to help better identify errors. There is further cleanup that could be done but this seemed like a decent place to stop. This is a mildly breaking change (I aligned the arguments to the functions so they match) but largely tries to keep compatibility.