Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(github): OAuth for GitHub #2016

Merged
merged 16 commits into from
Aug 22, 2023

chore: address comments related to DRYing up logic

4fabbbb
Select commit
Loading
Failed to load commit list.
Merged

feat(github): OAuth for GitHub #2016

chore: address comments related to DRYing up logic
4fabbbb
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Aug 21, 2023 in 0s

45.23% of diff hit (target 70.88%)

View this Pull Request on Codecov

45.23% of diff hit (target 70.88%)

Annotations

Check warning on line 131 in internal/cmd/auth.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/cmd/auth.go#L124-L131

Added lines #L124 - L131 were not covered by tests

Check warning on line 227 in internal/cmd/auth.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/cmd/auth.go#L225-L227

Added lines #L225 - L227 were not covered by tests

Check warning on line 235 in internal/cmd/auth.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/cmd/auth.go#L229-L235

Added lines #L229 - L235 were not covered by tests

Check warning on line 239 in internal/cmd/auth.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/cmd/auth.go#L237-L239

Added lines #L237 - L239 were not covered by tests

Check warning on line 241 in internal/cmd/auth.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/cmd/auth.go#L241

Added line #L241 was not covered by tests

Check warning on line 121 in internal/config/authentication.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/config/authentication.go#L117-L121

Added lines #L117 - L121 were not covered by tests

Check warning on line 123 in internal/config/authentication.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/config/authentication.go#L123

Added line #L123 was not covered by tests

Check warning on line 66 in internal/server/auth/method/github/server.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/server/auth/method/github/server.go#L54-L66

Added lines #L54 - L66 were not covered by tests

Check warning on line 71 in internal/server/auth/method/github/server.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/server/auth/method/github/server.go#L70-L71

Added lines #L70 - L71 were not covered by tests

Check warning on line 77 in internal/server/auth/method/github/server.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/server/auth/method/github/server.go#L74-L77

Added lines #L74 - L77 were not covered by tests

Check warning on line 96 in internal/server/auth/method/github/server.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/server/auth/method/github/server.go#L94-L96

Added lines #L94 - L96 were not covered by tests

Check warning on line 102 in internal/server/auth/method/github/server.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/server/auth/method/github/server.go#L101-L102

Added lines #L101 - L102 were not covered by tests

Check warning on line 106 in internal/server/auth/method/github/server.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/server/auth/method/github/server.go#L105-L106

Added lines #L105 - L106 were not covered by tests

Check warning on line 115 in internal/server/auth/method/github/server.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/server/auth/method/github/server.go#L114-L115

Added lines #L114 - L115 were not covered by tests

Check warning on line 128 in internal/server/auth/method/github/server.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/server/auth/method/github/server.go#L127-L128

Added lines #L127 - L128 were not covered by tests

Check warning on line 136 in internal/server/auth/method/github/server.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/server/auth/method/github/server.go#L135-L136

Added lines #L135 - L136 were not covered by tests

Check warning on line 150 in internal/server/auth/method/github/server.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/server/auth/method/github/server.go#L149-L150

Added lines #L149 - L150 were not covered by tests