-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: config init #2147
feat: config init #2147
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2147 +/- ##
==========================================
- Coverage 70.25% 70.18% -0.07%
==========================================
Files 76 76
Lines 7167 7151 -16
==========================================
- Hits 5035 5019 -16
+ Misses 1837 1834 -3
- Partials 295 298 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I wonder if we do need all the Redis cache stuff written out to the configuration file if |
yeah that's a good point, would require us to implement custom We should prob come up with a rubric of where to draw the line as in what gets written to the default config and what doesn't. Like should |
@yquansah checkout the updated output in the PR description to see what I got it down to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@markphelps This looks good to me!
Fixes: FLI-600
exploration to add a new command/subcommand:
This will write a default config.yml file to the user's home config directory. Mostly to enable getting up and running quickly with local Flipt
Here is the config it generates:
Also
On Errors
Going forward, I think we should adopt the position that there are two types of errors:
flipt foo
). These errors should be logged to STDERR without logging/formattingERROR
log level.