feat(tracing): add OTLP headers config #2148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @rudineirk thank you for the PR! This seems very reasonable and straightforward. With this we are going to have to make some changes to our documentation as well. |
markphelps
approved these changes
Sep 19, 2023
There was a problem hiding this comment.
another amazing PR @rudineirk ! Thank you! will get this merged
auto-merge was automatically disabled
September 19, 2023 14:46
Head branch was pushed to by a user without write access
rudineirk
force-pushed
the
feat/add-otlp-headers-config
branch
from
f44b815
to
e3deab5
Compare
|
Fixed a problem in the jsonschema, it was breaking some tests |
Codecov Report
@@ Coverage Diff @@
## main #2148 +/- ##
==========================================
- Coverage 70.64% 70.63% -0.01%
==========================================
Files 73 73
Lines 7066 7067 +1
==========================================
Hits 4992 4992
- Misses 1788 1789 +1
Partials 286 286
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
yquansah
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Necessary to send OTLP tracing data to servers like NewRelic:
https://docs.newrelic.com/docs/more-integrations/open-source-telemetry-integrations/opentelemetry/get-started/opentelemetry-set-up-your-app/