feat: libsql experiment #2178
feat: libsql experiment #2178
Conversation
markphelps
commented
Sep 30, 2023
•
markphelps
commented
- libsql support
- update to go 1.21
Codecov Report
@@ Coverage Diff @@
## main #2178 +/- ##
==========================================
+ Coverage 70.84% 70.92% +0.08%
==========================================
Files 77 77
Lines 7307 7334 +27
==========================================
+ Hits 5177 5202 +25
- Misses 1831 1833 +2
Partials 299 299
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| @@ -36,12 +36,39 @@ func TestOpen(t *testing.T) { | |||
| { | |||
| name: "sqlite url", | |||
| cfg: config.DatabaseConfig{ | |||
| URL: "file:flipt.db", | |||
| URL: "file:/flipt.db", | |||
There was a problem hiding this comment.
is this backward compatible? ie does it also work with file:flipt.db ?
There was a problem hiding this comment.
@markphelps Yes it seems to work with file:flipt.db as well.
There was a problem hiding this comment.
can you add a test just to be sure?
Uffizzi Ephemeral Environment
|
| @@ -0,0 +1,26 @@ | |||
| FROM golang:1.21-alpine3.18 | |||
There was a problem hiding this comment.
Is this one still needed?
I can't remember how that conversation ended.
There was a problem hiding this comment.
i think it still is for the dev docker-compose to not build the UI in the Go binary
