Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow disabling profiling endpoints #2195

Merged
merged 3 commits into from
Oct 4, 2023
Merged

feat: allow disabling profiling endpoints #2195

merged 3 commits into from
Oct 4, 2023

Conversation

markphelps
Copy link
Collaborator

Re: #2194

markphelps
markphelps commented Oct 3, 2023
View reviewed changes
internal/config/config.go
Cache CacheConfig `json:"cache,omitempty" mapstructure:"cache" yaml:"cache,omitempty"`
Cors CorsConfig `json:"cors,omitempty" mapstructure:"cors" yaml:"cors,omitempty"`
Database DatabaseConfig `json:"db,omitempty" mapstructure:"db" yaml:"db,omitempty"`
Diagnostics DiagnosticConfig `json:"diagnostics,omitempty" mapstructure:"diagnostics" yaml:"diagnostics,omitempty"`
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was the only addition, the rest were just re-organized in alphabetical order

@codecov
Copy link

codecov bot commented Oct 3, 2023 •
edited
Loading

Codecov Report

Merging #2195 (8a75719) into main (0a29bbf) will increase coverage by 0.02%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##             main    #2195      +/-   ##
==========================================
+ Coverage   70.55%   70.58%   +0.02%     
==========================================
  Files          76       77       +1     
  Lines        7240     7257      +17     
==========================================
+ Hits         5108     5122      +14     
- Misses       1833     1836       +3     
  Partials      299      299
Files Coverage Δ
internal/config/config.go 87.39% <100.00%> (+0.22%) ⬆️
internal/config/diagnostics.go 100.00% <100.00%> (ø)
internal/cmd/http.go 3.04% <0.00%> (-0.06%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@markphelps markphelps changed the title feat(wip): allow disabling profiling endpoints feat: allow disabling profiling endpoints Oct 3, 2023
@markphelps markphelps marked this pull request as ready for review October 3, 2023 20:23
@markphelps markphelps requested a review from a team as a code owner October 3, 2023 20:23
yquansah
yquansah approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@yquansah yquansah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good!

@markphelps markphelps merged commit 08e8450 into main Oct 4, 2023
25 checks passed
@markphelps markphelps deleted the allow-disabling-profiler branch October 4, 2023 13:50
@markphelps markphelps added the needs docs Requires documentation updates label Oct 4, 2023
@markphelps markphelps removed the needs docs Requires documentation updates label Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeorgeMac GeorgeMac GeorgeMac approved these changes

@yquansah yquansah yquansah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@markphelps @GeorgeMac @yquansah