fix(ui): prevent reload after logout

[erka]

No description provided.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.59%. Comparing base (f997fb9) to head (e53d2c2).
Report is 401 commits behind head on main.

❗ Current head e53d2c2 differs from pull request most recent head 3536b54

Please upload reports for the commit 3536b54 to get more accurate results.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3149      +/-   ##
==========================================
+ Coverage   70.78%   71.59%   +0.80%     
==========================================
  Files          91      109      +18     
  Lines        8729     7987     -742     
==========================================
- Hits         6179     5718     -461     
+ Misses       2165     1842     -323     
- Partials      385      427      +42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[erka]

@markphelps I have one more thought about authentication for Flipt Cloud. I wonder what will happen when token is expired. Currently ui just reloads itself.

flipt/ui/src/data/api.ts

Lines 34 to 39 in 22a157c

	if (!response.ok) {
	if (response.status === 401) {
	window.localStorage.removeItem(csrfTokenHeaderKey);
	window.localStorage.removeItem(sessionKey);
	window.location.reload();
	}

Is it okay with Flipt Cloud?

[markphelps]

@markphelps I have one more thought about authentication for Flipt Cloud. I wonder what will happen when token is expired. Currently ui just reloads itself.

flipt/ui/src/data/api.ts

Lines 34 to 39 in 22a157c

	if (!response.ok) {
	if (response.status === 401) {
	window.localStorage.removeItem(csrfTokenHeaderKey);
	window.localStorage.removeItem(sessionKey);
	window.location.reload();
	}

Is it okay with Flipt Cloud?

I think if the ui reloads itself if Flipt Cloud is the only authentication method then they will just see the no configured providers screen in the Flipt UI. Maybe we should redirect them back to the iss (flipt cloud) here as well if the token is expired/we get a 401

[markphelps]

one question! otherwise lgtm!

[markphelps]

looks great! thank you!