Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(build): remove namespace from IT matrix and move into harness #3150

Merged
merged 4 commits into from
Jun 6, 2024

Conversation

GeorgeMac
Copy link
Contributor

Related to #3144

I am working on a series of refactors to make our ITs clearer and ultimately faster (due to less work).
The primary motivation is we intend to introduce authz test suites to the ITs in the coming week.
However, our ITs are already exploding a little too much.
So, we decided to remove some of the dimensions from the integration matrix at the Dagger level.
This is starting with namespace in this PR.
I will continue to auth next and that will be a bigger shift in how we go about testing auth.

In this PR, namespace is dropped from the test harness matrix.
Instead, namespace is now a parameter that is exercised in the harness itself.
This results in a considerably quicker suite, as we half the number of isolated entire IT suites.
The tests in the harness itself still exercises the different namespace arguments (empty, default and production).

Note: I also dropped all the edge cases for namespaced tokens.
This was deliberate as they already over complicated things and it got more confusing without the namespace scope.
Instead, this will be reinstated when with come to explicitly address authz (very shortly after I do the auth refactor).

@GeorgeMac GeorgeMac requested a review from a team as a code owner June 6, 2024 09:55
Copy link
Collaborator

@markphelps markphelps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@markphelps markphelps added the automerge Used by Kodiak bot to automerge PRs label Jun 6, 2024
@kodiakhq kodiakhq bot merged commit 54ce56a into main Jun 6, 2024
30 checks passed
@kodiakhq kodiakhq bot deleted the gm/refactor-its-namespace branch June 6, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Used by Kodiak bot to automerge PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants