refactor(build): remove namespace from IT matrix and move into harness #3150
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #3144
I am working on a series of refactors to make our ITs clearer and ultimately faster (due to less work).
The primary motivation is we intend to introduce
authz
test suites to the ITs in the coming week.However, our ITs are already exploding a little too much.
So, we decided to remove some of the dimensions from the integration matrix at the Dagger level.
This is starting with
namespace
in this PR.I will continue to
auth
next and that will be a bigger shift in how we go about testing auth.In this PR, namespace is dropped from the test harness matrix.
Instead,
namespace
is now a parameter that is exercised in the harness itself.This results in a considerably quicker suite, as we half the number of isolated entire IT suites.
The tests in the harness itself still exercises the different namespace arguments (empty, default and production).
Note: I also dropped all the edge cases for namespaced tokens.
This was deliberate as they already over complicated things and it got more confusing without the namespace scope.
Instead, this will be reinstated when with come to explicitly address
authz
(very shortly after I do theauth
refactor).