-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(audit): preserve audit log scheme #3151
Conversation
thanks @erka ! much better that its a non-breaking change now! i think we just need to fix the unit tests to account for this |
@markphelps I've already pushed the changed but it looks like Github has some issues. It shows the |
@erka hmm maybe try pushing an empty commit? maybe GitHub was having some issues? |
Signed-off-by: Roman Dmytrenko <[email protected]>
2560d6b
to
492cd8b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3151 +/- ##
==========================================
+ Coverage 70.78% 71.65% +0.87%
==========================================
Files 91 106 +15
Lines 8729 7879 -850
==========================================
- Hits 6179 5646 -533
+ Misses 2165 1791 -374
- Partials 385 442 +57 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Roman Dmytrenko <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
related to #3101 #3113 (comment)