-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support environment variable substitution in config files #3195
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3195 +/- ##
==========================================
+ Coverage 70.78% 71.55% +0.76%
==========================================
Files 91 109 +18
Lines 8729 8004 -725
==========================================
- Hits 6179 5727 -452
+ Misses 2165 1848 -317
- Partials 385 429 +44 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great @mbezhanov !! thank you for the contribution! would you mind going through the step required to sign the DCO?
https://github.com/flipt-io/flipt/pull/3195/checks?check_run_id=26421002517
@all-contributors please add @mbezhanov for code |
I've put up a pull request to add @mbezhanov! 🎉 |
Signed-off-by: Marin Bezhanov <[email protected]>
Done! 🙂 |
…o authz-opa-sdk * 'authz-opa-sdk' of https://github.com/flipt-io/flipt: docs: add mbezhanov as a contributor for code (#3197) feat: support environment variable substitution in config files (#3195)
Hi.
This PR implements the changes suggested in #2844.
The proposed format is
${VARIABLE}
like in the envsubst Linux command, but I can tweak it however you like.If any further changes are necessary, I'll be happy to add them.