Add support for php 8 attributes #64
Conversation
Refactor the current schema generation test case in order to reuse the same logic for schema generation with php 8 attributes. Create a new schema attribute reader for extracting schema info from php attributes.
|
|
||
| namespace FlixTech\AvroSerializer\Objects\Schema\Generation\Attributes; | ||
|
|
||
| enum Type: string |
There was a problem hiding this comment.
That would require to bump min. version to 8.1, right ?
There was a problem hiding this comment.
Also here, min version for this library is PHP 7.4
There was a problem hiding this comment.
Not necessarily. These enums are being used only by the "attributes reader" code, so if one does not use that than php 8.1 won't be required, right?
There was a problem hiding this comment.
Nope, the files get parsed for static code analysis and code coverage. We would have to ignore them individually for each of these tools, and I am not even sure if that is possible.
There was a problem hiding this comment.
I've found some ways of doing so by conditionalling excluding those files when the php version is not supported. I've prepended these commits as WIP just for testing puprposes. It workerd locally, let's see how it goes.
|
|
||
| namespace FlixTech\AvroSerializer\Objects\Schema\Generation\Attributes; | ||
|
|
||
| enum Order: string |
There was a problem hiding this comment.
We cannot support this yet in this library, we are supporting PHP 7.4 here
|
|
||
| namespace FlixTech\AvroSerializer\Objects\Schema\Generation\Attributes; | ||
|
|
||
| enum Type: string |
There was a problem hiding this comment.
Also here, min version for this library is PHP 7.4
xico42
force-pushed
the
schema-attributes
branch
from
4bb766e
to
d7a08de
Compare
- Refactor unit tests in order to remove php 8.1 specific tests from older php versions - Conditionally remove or add code to static analysis based on the current php version - Update minimum phpunit version
xico42
force-pushed
the
schema-attributes
branch
from
032eca6
to
c298a36
Compare
xico42
force-pushed
the
schema-attributes
branch
from
1c0b6f5
to
8a8ca50
Compare
| @@ -33,6 +33,10 @@ jobs: | |||
| - | |||
| version: 8.0 | |||
| xdebug: 3.1.1 | |||
|
|
|||
| - | |||
| version: 8.1.0RC3 | |||
There was a problem hiding this comment.
| version: 8.1.0RC3 | |
| version: 8.1.0 |
Now that 8.1 is out
| @@ -6,6 +6,13 @@ | |||
| ->in(['src', 'test']) | |||
| ; | |||
|
|
|||
| if (version_compare(PHP_VERSION, '8.1') < 0) { | |||
There was a problem hiding this comment.
Can't we make it work on 8.0 if we don't use nested attributes?
|
Any update on this? It would be nice to use PHP attributes instead of annotations. |
|
@AlexOstrovsky, I'd be happy if someone takes this PR as a base and adds the required changes. Also, PHP 7.4 is dropped, so it would make things easier. As said before, I am currently not able to do this. |
Refactor the current schema generation test case in order to reuse the
same logic for schema generation with php 8 attributes.
Create a new schema attribute reader for extracting schema info from php
attributes.
Once nested attributes is supported only in php 8.1, this feature supports only php >= 8.1.