Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Underscore in field name #314

Merged
merged 2 commits into from
Jan 8, 2025
Merged

Underscore in field name #314

merged 2 commits into from
Jan 8, 2025

Conversation

wilmveel
Copy link
Contributor

@wilmveel wilmveel commented Jan 7, 2025 •
edited
Loading

Allow underscore in field name
Regex("^[a-z][a-zA-Z0-9_]*") to CustomValue

@wilmveel wilmveel linked an issue Jan 7, 2025 that may be closed by this pull request
Underscore in keynames cannot be escaped #301
Closed
ZzAve
ZzAve approved these changes Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@ZzAve ZzAve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jerrevanveluw jerrevanveluw merged commit 103392c into master Jan 8, 2025
8 checks passed
@jerrevanveluw jerrevanveluw deleted the 301-underscore-in-keynames-cannot-be-escaped branch January 8, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerrevanveluw jerrevanveluw jerrevanveluw approved these changes

@ZzAve ZzAve ZzAve approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Underscore in keynames cannot be escaped
3 participants
@wilmveel @ZzAve @jerrevanveluw