Muskaan 1g bx2 #103
Open
Muskaan 1g bx2 #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Muskaan Kapahi <[email protected]>
…-28DC-003/001: Shown as Unknown Signed-off-by: Muskaan Kapahi <[email protected]>
|
@sonoble @jnealtowns can you please have a look at my PR? |
|
@jnealtowns @sonoble |
sonoble
approved these changes
Sep 21, 2023
|
For ONL we now use https://github.com/opennetlinux/bigcode if you can put the commit there I can merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add code to fix the issue for 1G SFP-GE-BX40 and BX10 (BiDi) on S9510-28DC-003/001: Shown as Unknown
The code for 1G-SFP-GE-BX40 and BX10 was not added as a part of the repo, so it was functioning but it wasn't being recorded in the onlpdump
@sonoble @jnealtowns can you please review my PR?