-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android IME support #475
base: master
Are you sure you want to change the base?
Android IME support #475
Conversation
Bugfix and better performance in sokol_app.h, no known bugs now |
Thanks for the PR, but TBH, currently it looks too messy to be considered. There are big code blocks inside (also there's a block of text in the README.md file which probably shouldn't be there). |
I am cleaning up the code, so many tricks when only using c, some comments are reserved for alternative options. It looks immature to merge now. Tested on Android 7.0, I published here for further evaluation, coming soon. |
Ah ok I see. You can set the Pull Request to "Draft" state as long as you're working on it: That way I also can't accidentally hit the "Merge" button ;) PS: turns out I can do this too, so I set the PR to "draft". |
PS:
No, I think it's better to discuss the PR right here. |
a08bec7
to
f7c1558
Compare
…should be clean in next commit
2021/02/13
update
util/sokol_imgui.h call functions in imgui_internal.h, so all imgui examples in sokol-samples should include "imgui_internal.h". I found a coding style of sokol: sokol_imgui.h doen't include some necessary headers, such as imgui.h, It depends on examples to include these headers. So any extra headers which sokol_imgui.h needs will cause modification of sokol-samples.
I will submit the modifications in sokol-samples soon
2021/02/13
I think it's ready to merge ;)
2021/02/11
based on checkout of sokol and sokol-samples on 2021/02/11
Android ImGui IME support. Simple Information: