Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] multiwindow support #526

Draft
wants to merge 50 commits into
base: master
Choose a base branch
from
Draft

[WIP] multiwindow support #526

wants to merge 50 commits into from

Conversation

floooh
Copy link
Owner

@floooh floooh commented Jun 1, 2021 •
edited
Loading

...heavily WIP, just for tracking what has been done and what needs to be done.

  • sokol_app.h macOS Metal: blargh, random crashes now in com.Metal.CompletionQueueDispatch when quickly resizing a borderless child window, where's that suddenly coming from :/ (hmm, this looks somewhat similar: Crash in com.Metal.CompletionQueueDispatch KhronosGroup/MoltenVK#510) => ok this happens when moving the [MTKView draw] method in front of the draw callback (so that the additional framebuffer textures are lazily updated before rendering starts, guess I need to ditch MTKView for realz and manage the depth-buffer and MSAA texture myself) :/
  • sokol_app.h macOS GL: new windows are flashing the background color for one frame (reason is that for the first two frames, the framebuffer size is reported as Retina-resolution, hmm... update: GLFW has the same behaviour, for non-retina windows, the framebuffer size is initially reported in Retina resolution before it switches to non-Retina)
  • sokol_app.h Metal: vertical mouse position in Dear ImGui when resizing 'child windows' is messed up, only in Metal!
  • sokol_app.h macOS: don't send resize events in first frame doesn't really make sense with multiple windows, instead use an "in_create_window" flag.
  • sokol_app.h macOS Metal + GL: implement per window high_dpi
  • sokol_app.h macOS Metal: new borderless windows that are not rendered to are completely invisible, which is quite confusing
  • sokol_app.h win32 + D3D11: implement multiwindow
  • sokol_app.h win32 + GL: implement multiwindow
  • sokol_app.h X11 + GL: implement multiwindow
  • sokol_app.h: update documentation
  • sokol_gfx.h: update documentation
  • sokol_app.h: for ImGui's multiviewport feature, need a new function to query the overall display size, including additional monitors (?) -> later probably proper multi-monitor support like in GLFW?
  • figure out how handle the single-window platforms (everything except Win32, macOS, Linux), should the per-window functions be empty stubs, unless the main window is accessed?

@floooh
sokol_app.h: start with multiwindow
f3f1661
@floooh
sokol_app.h: window pool code, and some better platform-specific code…
660b405 
… structure
@floooh
some intermediate code cleanup
6057fc6
@floooh
continue with macOS window code
292ab0f
@floooh
continue with macOS window code
0c74bce
@floooh
sokol_app.h macOS: multiwindow wip
58c8c4b
@floooh
sokol_app.h macOS: more multiwindow wip
8f86a72
@floooh
merge latest changes from master
5a34f90
@floooh
sokol_gfx.h: move Metal semaphore into _sg_context_t
1c5a562
@floooh
destroy main window last
6bc2e2d
@floooh
sokol_gfx.h metal: move uniform buffers into _sg_context_t
236be4b
@floooh
sokol_app.h metal: autoreleasepool in view's drawRect method
dd7b468
@floooh
sokol_gfx.h: keep track of rendered context frames
205e031
@floooh
sokol_gfx.h: each context has its own MTLCommandQueue
e59af70
@floooh
sokol_app.h: experiement with GLFW-style render loop
f361165
@floooh
sokol_app.h: go back to application callbacks instead of window callb…
7ea7a4f 
…acks
@floooh
sokol_app.h: trigger rendering with CVDisplayLink
baf1327
@floooh
sokol_app.h metal: add window rps and drawable callbacks
e089f51
@floooh
sokol_gfx.h: sg_commit loops through all active contexts
abf6d31
@floooh
sokol_glue.h: helper function to fill per-window sg_context_desc
852fbb9
@floooh
sokol_app.h: single-window vs multi-window APIs
e66df10
@floooh
sokol_app.h: start ditching MTKView, use CAMetalLayer directly
16cf91a
@floooh
Revert "sokol_app.h: start ditching MTKView, use CAMetalLayer directly"
99d7d88 
This reverts commit 16cf91a.
@floooh
more multiwindow wip
ccfdb17
@floooh
multiwindow intermediate code cleanup
23239cf
@floooh
sokol_gfx.h mtl: ignore context commit if context wasn't rendered to
a35bea5
@floooh
sokol_app.h metal: start to fix window close and shutdown behaviour
f79edaf
@floooh
sokol_app.h metal: fix window/framebuffer resizing
88d9295
@floooh
sokol_app.h: window closed event
9ece3f1
@floooh
add a temp fixme comment
2f6c1a5
floooh added 20 commits May 13, 2021 13:41
@floooh
sokol_app.h: per-window user data
1183c90
@floooh
sokol_app.h: programmatic window close
4260fb4
@floooh
more multiwindow wip
9738382
@floooh
sokol_app.h: start with window pos/size API
64afd39
@floooh
sokol_app.h macos: set/get window pos and size
c858e23
@floooh
sokol_app.h: no_decoration flag and sapp_window_slow_index() function
7862200
@floooh
sokol_app.h: show/hide window wip
bd1a6a7
@floooh
sokol_app.h macos: add remaining multi-window functions
770583b
@floooh
sokol_app.h macos: applicationShouldHandleReopen
3eba4fb 
This application delegate method is called when the dock icon
is clicked and will unminimize the main window in case
multiple windows are open.
@floooh
sokol_app.h macos gl: multiwindow wip
df8a7fd
@floooh
sokol_app.h macos gl: more multiwindow wip
bb6dd74
@floooh
sokol_app.h macos gl: make multiwindow basically work (minus a memory…
7f70b2d 
… leak)
@floooh
sokol_gfx.h: activate default context if active context is destroyed
15c9596
@floooh
sokol_app.h macos gl: fix NSOpenGLContext memory leak
bc64d6f
@floooh
sokol_app.h: intermediate code cleanup
b7cfef5
@floooh
sokol_gfx.h: de-associate resources and contexts
ccdb7e9
@floooh
sokol_gfx_imgui.h: remove per resource context id, and context mismat…
847076f 
…ch error hook
@floooh
sokol_app.h GL: fix initial wrongly reported framebuffer size for non…
5a1ff5b 
…-Retina case
@floooh
sokol_app.h metal: fix MTKView internal texture resize
3c2fa0b
@floooh
sokol_app.h macos: fix inverted y mouse pos computation
57688eb
@floooh floooh mentioned this pull request Sep 13, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@floooh