Android Hardware Keyboard/Back Button Support #869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add SAPP keycode for the Android Back Button - Implement KEY_DOWN/KEY_UP/CHAR events with repeat support - Implemented quit_requested/quit_ordered so that sapp_request_quit() works These changes allows Android app to recieve an action for a back button press and respond to it themselves (including navigation and exiting the application) and allows Android HW keyboards to function just like the Windows/macOS/Linux keyboards.
|
I have a couple of nitpicks, but first, do you know if I can test the hardware keyboard support somehow with my Android phone (e.g. can I attach a USB keyboard for testing?) |
floooh
requested changes
Aug 15, 2023
There was a problem hiding this comment.
Just a couple of formatting things to take care of.
Please also check the errors CI (sign-conversion warning - yes the CI pipeline settings are very picky), and SOKOL_LOG has been replaced, but I guess you can just remove all logs unless they are actual warnings and errors.
Not sure, but the Android Emulator in Android Studio relays the computer keyboard input as Android hardware keyboard events. I'll also work through those recommended changes later tonight. |
|
I was also wondering, do you want me to wire up all the android specific keycodes to new sokol scan codes (tv remotes, gamepad keys, etc), or just keep to the minimal set here. |
… block propagation of all consumed events
If it's just a handful or so and you think it's a good idea to do so, feel free to add those as |
|
Also please have a look at the 'new' errors in CI, there's some problem when compiling as C++, those JNI calls may need some Lines 8376 to 8390 in 47d92ff PS: I mean the errors in here: https://github.com/floooh/sokol/actions/runs/5876724894/job/15942332488?pr=869 ...ignore the Odin-related issue in that other CI job, don't know yet what's up with that, but it's definitely not related to your PR. |
Its going to be quite a few if we want to cover the complete android keyset, take a look at this switch statement below to see what the full list looks like. |
|
Oh hmm ok, that's a lot more than I was hoping. Are there any other important keys that would make sense to support except the Back button? I was thinking up to 10 or so Android-specific keys would be ok (or we can just go with the just the Back button for now and add more on demand later). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes allow Android apps to receive an event for a back button press and respond to it themselves (including consuming it for their navigation purposes and exiting the application) and allows Android HW keyboards to function just like the Windows/macOS/Linux keyboards.
Overview of the changes: