Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Done fix #955

Open
wants to merge 104 commits into
base: i210_dev
Choose a base branch
from
Open

Done fix #955

wants to merge 104 commits into from

Conversation

eugenevinitsky
Copy link
Member

The done condition is not correct for sims_per_step greater than one. Its possible a vehicle might have left during one of the steps. Additionally, fix the done condition to get set when a vehicle is on the exit edge.

@eugenevinitsky
Copy link
Member Author

I'm not sure why this isn't getting the histories right, this is built on top of I210 dev...

Copy link
Member

@AboudyKreidieh AboudyKreidieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eugenevinitsky can you rebase this with i210_dev? I can review it afterwards

Yasharzf and others added 6 commits June 11, 2020 10:29
* added new lane change modes

* replaced 'no_lat_collide' with 'no_lc_safe' which is the new default lane change mode

* bug fixes and PR reviews

Co-authored-by: AboudyKreidieh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants