Better handling of empty candidates in forward #36
+6
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
253
to
254
| elif len(candidates) == 0 and len(contexts) > 0: | ||
| candidates = [[""] for _ in contexts] |
There was a problem hiding this comment.
Why did you add this elif clause? Isn't the else enough?
There was a problem hiding this comment.
Well not exactly. The elif authorizes candidates=[]. I guess I could merge it with the if above with an or operator:
if candidates is None or len(candidates) == 0:
candidates = [[""] for _ in range(len(contexts))]
else:
assert len(candidates) == len(contexts), "If candidates are provided, there should be one list of candidates per context."
if any([len(_c) == 0 for _c in candidates]):
candidates = [[""] if len(_c) == 0 else _c for _c in candidates]
|
This line also seems unnecessary: |
Yes you're right. I'm doing a new commit without this line. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.