Better handling of empty candidates in forward

[ClementRomac]

No description provided.

[sadra-barikbin]

Why did you add this elif clause? Isn't the else enough?

[ClementRomac]

Well not exactly. The elif authorizes candidates=[]. I guess I could merge it with the if above with an or operator:

if candidates is None or len(candidates) == 0:
    candidates = [[""] for _ in range(len(contexts))]
else:
    assert len(candidates) == len(contexts), "If candidates are provided, there should be one list of candidates per context."
    if any([len(_c) == 0 for _c in candidates]):
        candidates = [[""] if len(_c) == 0 else _c for _c in candidates]

[sadra-barikbin]

This line also seems unnecessary:

lamorel/lamorel/src/lamorel/server/llms/hf_llm.py

Line 294 in c82d1b1

if len(_ids_tables[_i]) == 0: break

[ClementRomac]

This line also seems unnecessary:

lamorel/lamorel/src/lamorel/server/llms/hf_llm.py

Line 294 in c82d1b1

if len(_ids_tables[_i]) == 0: break

Yes you're right. I'm doing a new commit without this line.