fix for 'nested transactions nod supported' issue on drag node #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forresto
reviewed
Oct 24, 2018
…action is ended and state reset
|
Hi. Can you remove all the style changes? It becomes hard to see what actually changed, in order to do a review. |
|
hi @forresto @jonnor - I've removed all the lint changes stuff ( sorry forgot to turn it off in my editor ), and the updated dependency stuff, as requested. I've added an .nvmrc file too specifying to use LTS - there are install issues with latest ( v11 ) in the prebuilt-canvas package. There are still issues with the render-cli tests though, so CI is failing. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
checks the state of a node when starting to drag - if it thinks its already dragging then reset the state and end the move transaction before starting a new one