feat: upgrade esbuld version, drop node 14 in pipelines, use nodejs18… (

#552) * feat: upgrade esbuld version, drop node 14 in pipelines, use nodejs18.x as default runtime * fix: update esbuild-node-externals to version 1.14.0 * fix: esbuild-node-externals breaking change usage * test: fix test failing in node 20 and higher
floydspace · Sep 21, 2024 · 6deddd2 · 6deddd2
1 parent 7dc3b64
commit 6deddd2
Show file tree

Hide file tree

Showing 20 changed files with 301 additions and 242 deletions.
diff --git a/.github/workflows/pull.yml b/.github/workflows/pull.yml
@@ -10,7 +10,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node-version: [14, 16, 18]
+        node-version: [18, 20, 22]
     steps:
       - uses: actions/checkout@v3
       - name: Use Node.js ${{ matrix.node-version }}

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -10,7 +10,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node-version: [14, 16, 18]
+        node-version: [18, 20, 22]
     steps:
       - uses: actions/checkout@v3
       - name: Use Node.js ${{ matrix.node-version }}
@@ -28,7 +28,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: 18
       - run: npm ci
       - run: npx semantic-release
         env:

diff --git a/README.md b/README.md
@@ -103,7 +103,7 @@ The following `esbuild` options are automatically set.
 | `entryPoints` | N/A        | Cannot be overridden                                                   |
 | `outDir`      | N/A        | Cannot be overridden                                                   |
 | `platform`    | `'node'`   | Set `format` to `esm` to enable ESM support                            |
-| `target`      | `'node16'` | We dynamically set this. See [Supported Runtimes](#supported-runtimes) |
+| `target`      | `'node18'` | We dynamically set this. See [Supported Runtimes](#supported-runtimes) |
 | `watch`       | N/A        | Cannot be overridden                                                   |
 
 #### Packager Options

diff --git a/e2e/__snapshots__/complete.test.ts.snap b/e2e/__snapshots__/complete.test.ts.snap
@@ -311,7 +311,7 @@ exports[`complete 5`] = `
           "Arn",
         ],
       },
-      "Runtime": "nodejs12.x",
+      "Runtime": "nodejs18.x",
       "Timeout": 6,
     },
     "Type": "AWS::Lambda::Function",

diff --git a/e2e/__snapshots__/individually.test.ts.snap b/e2e/__snapshots__/individually.test.ts.snap
@@ -227,7 +227,7 @@ exports[`individually 6`] = `
           "Arn",
         ],
       },
-      "Runtime": "nodejs12.x",
+      "Runtime": "nodejs18.x",
       "Timeout": 6,
     },
     "Type": "AWS::Lambda::Function",
@@ -295,7 +295,7 @@ exports[`individually 6`] = `
           "Arn",
         ],
       },
-      "Runtime": "nodejs12.x",
+      "Runtime": "nodejs18.x",
       "Timeout": 6,
     },
     "Type": "AWS::Lambda::Function",

diff --git a/e2e/__snapshots__/minimal.test.ts.snap b/e2e/__snapshots__/minimal.test.ts.snap
@@ -14227,7 +14227,7 @@ exports[`minimal 5`] = `
           "Arn",
         ],
       },
-      "Runtime": "nodejs12.x",
+      "Runtime": "nodejs18.x",
       "Timeout": 6,
     },
     "Type": "AWS::Lambda::Function",

diff --git a/examples/complete/package.json b/examples/complete/package.json
@@ -9,7 +9,7 @@
   },
   "devDependencies": {
     "@types/node": "^18.7.21",
-    "esbuild": "^0.20.0",
+    "esbuild": "^0.23.0",
     "serverless": "^3.22.0",
     "serverless-esbuild": "file:../..",
     "serverless-offline": "^10.2.1",

diff --git a/examples/complete/serverless.yml b/examples/complete/serverless.yml
@@ -16,7 +16,7 @@ custom:
 
 provider:
   name: aws
-  runtime: nodejs12.x
+  runtime: nodejs18.x
 
 functions:
   validateIsin:

diff --git a/examples/config/package.json b/examples/config/package.json
@@ -9,7 +9,7 @@
   "devDependencies": {
     "@types/lodash": "4.14.185",
     "@types/node": "^18.7.21",
-    "esbuild": "^0.20.0",
+    "esbuild": "^0.23.0",
     "serverless": "^3.22.0",
     "serverless-esbuild": "file:../..",
     "serverless-offline": "^10.2.1"

diff --git a/examples/config/serverless.yml b/examples/config/serverless.yml
@@ -9,7 +9,7 @@ package:
 
 provider:
   name: aws
-  runtime: nodejs12.x
+  runtime: nodejs18.x
 
 custom:
   esbuild:

diff --git a/examples/individually/package.json b/examples/individually/package.json
@@ -9,7 +9,7 @@
   "devDependencies": {
     "@types/lodash": "4.14.185",
     "@types/node": "^18.7.21",
-    "esbuild": "^0.20.0",
+    "esbuild": "^0.23.0",
     "serverless": "^3.22.0",
     "serverless-esbuild": "file:../..",
     "serverless-offline": "^10.2.1"

diff --git a/examples/individually/serverless.yml b/examples/individually/serverless.yml
@@ -9,7 +9,7 @@ package:
 
 provider:
   name: aws
-  runtime: nodejs12.x
+  runtime: nodejs18.x
 
 custom:
   esbuild:

diff --git a/examples/minimal/package.json b/examples/minimal/package.json
@@ -9,7 +9,7 @@
   },
   "devDependencies": {
     "@types/node": "^18.7.21",
-    "esbuild": "^0.20.0",
+    "esbuild": "^0.23.0",
     "serverless": "^3.22.0",
     "serverless-esbuild": "file:../..",
     "serverless-offline": "^10.2.1"

diff --git a/examples/minimal/serverless.yml b/examples/minimal/serverless.yml
@@ -6,7 +6,7 @@ plugins:
 
 provider:
   name: aws
-  runtime: nodejs12.x
+  runtime: nodejs18.x
 
 functions:
   validateIsin: