Tree making overrun in UMAP - fixes #277 and #278 #279
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tree-making seems to need to remove the front of the matrix - there is a boolean in the algo, but since tree making can be run on a square matrix elsewhere in the codebase, this was creating an overflow in UMAP as the client was not checking for a smaller number of neighbour than the number of points.
@weefuzzy and @g-roma if the rejection of the first item at UMAP.hpp:373 in fluid::algorithm::UMAP::makeGraph is right for the algo (I am not certain) then this fixes everything.