Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removes the word rows from ds.print and the interface of dsquery.limit #280

Merged
merged 4 commits into from
Oct 31, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions include/clients/nrt/DataSetQueryClient.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -144,10 +144,10 @@ class DataSetQueryClient : public FluidBaseClient, OfflineIn, OfflineOut
return OK();
}

MessageResult<void> limit(index rows)
MessageResult<void> limit(index points)
{
if (rows <= 0) return Error("invalid value");
mAlgorithm.limit(rows);
if (points <= 0) return Error("invalid limit on the number of points");
mAlgorithm.limit(points);
return OK();
}

Expand Down
2 changes: 1 addition & 1 deletion include/data/FluidDataSet.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ class FluidDataSet
using namespace std;
if (size() == 0) return "{}";
ostringstream result;
result << endl << "rows: " << size() << " cols: " << pointSize() << endl;
result << endl << "points:" << size() << " cols:" << pointSize() << endl;
if (size() < maxRows)
{
for (index r = 0; r < size(); r++)
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@

rows: 100 cols: 100
points:100 cols:100
0 0 1 2 ... 97 98 99
0 100 101 102 ... 197 198 199
0 200 201 202 ... 297 298 299
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@

rows: 2 cols: 5
points:2 cols:5
zero 0 1 2 3 4
one 5 6 7 8 9

Loading